linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Michael Neuling <mikey@neuling.org>
To: Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>,
	Michael Ellerman <mpe@ellerman.id.au>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc/powernv/cpuidle: Pass correct drv->cpumask for registration
Date: Sat, 18 Mar 2017 16:28:02 +1100	[thread overview]
Message-ID: <1489814882.5616.11.camel@neuling.org> (raw)
In-Reply-To: <20170317180550.9931-1-svaidy@linux.vnet.ibm.com>

Vaidy,

Thanks for fixing this.

> drv->cpumask defaults to cpu_possible_mask in __cpuidle_driver_init().
> This breaks cpuidle on powernv where sysfs files are not created for
> cpus in cpu_possible_mask that cannot be hot-added.

I think I prefer the longer description below than this.

> This patch fixes the issue by passing correct cpumask from
> powernv-cpuidle driver.

Any reason the correct fix isn't to change __cpuidle_driver_init() to use
present mask?  Seems like any arch where present < possible is going to hit
this.

> Signed-off-by: Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>

Can we CC stable too.  This breaks at least v4.10.

> ---
> =C2=A0drivers/cpuidle/cpuidle-powernv.c | 22 ++++++++++++++++++++++
> =C2=A01 file changed, 22 insertions(+)
>=20

  reply	other threads:[~2017-03-18  5:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-17 18:05 [PATCH] powerpc/powernv/cpuidle: Pass correct drv->cpumask for registration Vaidyanathan Srinivasan
2017-03-18  5:28 ` Michael Neuling [this message]
2017-03-18  6:53   ` Vaidyanathan Srinivasan
2017-03-20  3:05     ` Michael Ellerman
2017-03-20  4:31       ` Vaidyanathan Srinivasan
2017-03-22 10:55         ` Michael Ellerman
2017-03-23  3:59           ` Vaidyanathan Srinivasan
2017-03-19  5:55 ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1489814882.5616.11.camel@neuling.org \
    --to=mikey@neuling.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=svaidy@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).