From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>,
Michael Neuling <mikey@neuling.org>,
Michael Ellerman <mpe@ellerman.id.au>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc/powernv/cpuidle: Pass correct drv->cpumask for registration
Date: Sun, 19 Mar 2017 16:55:33 +1100 [thread overview]
Message-ID: <1489902933.2504.21.camel@kernel.crashing.org> (raw)
In-Reply-To: <20170317180550.9931-1-svaidy@linux.vnet.ibm.com>
On Fri, 2017-03-17 at 23:35 +0530, Vaidyanathan Srinivasan wrote:
> + /*
> + * On PowerNV platform cpu_present may be less that cpu_possible
> + * in cases where firmware detects the cpu, but it is not available
> + * for OS. Such CPUs are not hotplugable at runtime on PowerNV
> + * platform and hence sysfs files are not created for those.
> + * Generic topology_init() would skip creating sysfs directories
> + * for cpus that are not present and not hotplugable later at
> + * runtime.
> + *
> +
I wouldn't assume that they can't later be hotplugged. We need that fix
now as it's hitting machines today but we'll need to improve all that
code and the topology code to deal with hotplugging gracefully.
Cheers,
Ben.
prev parent reply other threads:[~2017-03-19 5:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-17 18:05 [PATCH] powerpc/powernv/cpuidle: Pass correct drv->cpumask for registration Vaidyanathan Srinivasan
2017-03-18 5:28 ` Michael Neuling
2017-03-18 6:53 ` Vaidyanathan Srinivasan
2017-03-20 3:05 ` Michael Ellerman
2017-03-20 4:31 ` Vaidyanathan Srinivasan
2017-03-22 10:55 ` Michael Ellerman
2017-03-23 3:59 ` Vaidyanathan Srinivasan
2017-03-19 5:55 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1489902933.2504.21.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mikey@neuling.org \
--cc=mpe@ellerman.id.au \
--cc=svaidy@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).