From: Michael Ellerman <mpe@ellerman.id.au>
To: linuxppc-dev@ozlabs.org
Cc: aneesh.kumar@linux.vnet.ibm.com
Subject: [PATCH v6 11/19] powerpc/mm/hash: Check for non-kernel address in get_kernel_vsid()
Date: Thu, 30 Mar 2017 23:03:59 +1100 [thread overview]
Message-ID: <1490875447-4016-11-git-send-email-mpe@ellerman.id.au> (raw)
In-Reply-To: <1490875447-4016-1-git-send-email-mpe@ellerman.id.au>
get_kernel_vsid() has a very stern comment saying that it's only valid
for kernel addresses, but there's nothing in the code to enforce that.
Rather than hoping our callers are well behaved, add a check and return
a VSID of 0 (invalid).
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
---
arch/powerpc/include/asm/book3s/64/mmu-hash.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/powerpc/include/asm/book3s/64/mmu-hash.h b/arch/powerpc/include/asm/book3s/64/mmu-hash.h
index a5ab6f5b8a7f..10a34282829e 100644
--- a/arch/powerpc/include/asm/book3s/64/mmu-hash.h
+++ b/arch/powerpc/include/asm/book3s/64/mmu-hash.h
@@ -682,6 +682,9 @@ static inline unsigned long get_kernel_vsid(unsigned long ea, int ssize)
{
unsigned long context;
+ if (!is_kernel_addr(ea))
+ return 0;
+
/*
* For kernel space, we use context ids 1-4 to map the address space as
* below:
--
2.7.4
next prev parent reply other threads:[~2017-03-30 12:04 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-30 12:03 [PATCH v6 01/19] powerpc/mm/slice: Convert slice_mask high slice to a bitmap Michael Ellerman
2017-03-30 12:03 ` [PATCH v6 02/19] powerpc/mm/slice: Update the function prototype Michael Ellerman
2017-03-30 12:03 ` [PATCH v6 03/19] powerpc/mm: Move copy_mm_to_paca to paca.c Michael Ellerman
2017-03-30 12:03 ` [PATCH v6 04/19] powerpc/mm: Remove checks that TASK_SIZE_USER64 is too small Michael Ellerman
2017-03-30 12:03 ` [PATCH v6 05/19] powerpc/mm/slice: Move slice_mask struct definition to slice.c Michael Ellerman
2017-03-30 12:03 ` [PATCH v6 06/19] powerpc/mm/slice: Update slice mask printing to use bitmap printing Michael Ellerman
2017-03-30 12:03 ` [PATCH v6 07/19] powerpc/mm/hash: Abstract context id allocation for KVM Michael Ellerman
2017-03-30 12:03 ` [PATCH v6 08/19] powerpc/mm/hash: Pull hash constants into hash__alloc_context_id() Michael Ellerman
2017-03-30 12:03 ` [PATCH v6 09/19] powerpc/mm: Split radix vs hash mm context initialisation Michael Ellerman
2017-03-30 12:03 ` [PATCH v6 10/19] powerpc/mm/hash: Use context ids 1-4 for the kernel Michael Ellerman
2017-04-28 10:57 ` Michal Suchánek
2017-04-28 12:05 ` Michael Ellerman
2017-03-30 12:03 ` Michael Ellerman [this message]
2017-03-30 12:04 ` [PATCH v6 12/19] powerpc/mm/hash: Support 68 bit VA Michael Ellerman
2017-03-30 12:04 ` [PATCH v6 13/19] powerpc/mm/hash: Convert mask to unsigned long Michael Ellerman
2017-03-30 12:04 ` [PATCH v6 14/19] powerpc/mm/hash: Increase VA range to 128TB Michael Ellerman
2017-03-30 12:04 ` [PATCH v6 15/19] powerpc/mm: Add addr_limit to mm_context and use it to derive max slice index Michael Ellerman
2017-03-30 12:04 ` [PATCH v6 16/19] powerpc/mm/hash: Store addr_limit in PACA Michael Ellerman
2017-03-30 12:04 ` [PATCH v6 17/19] powerpc/pseries: Skip using reserved virtual address range Michael Ellerman
2017-03-30 12:04 ` [PATCH v6 18/19] powerpc/mm: Switch some TASK_SIZE checks to use mm_context addr_limit Michael Ellerman
2017-03-30 12:04 ` [PATCH v6 19/19] powerpc/mm: Enable mappings above 128TB Michael Ellerman
2017-04-03 10:13 ` [v6, 01/19] powerpc/mm/slice: Convert slice_mask high slice to a bitmap Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1490875447-4016-11-git-send-email-mpe@ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).