From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Anton Blanchard <anton@samba.org>, Nicholas Piggin <npiggin@gmail.com>
Cc: paulus@samba.org, mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc: Add POWER9 copy_page() loop
Date: Mon, 03 Apr 2017 11:01:51 +1000 [thread overview]
Message-ID: <1491181311.26047.23.camel@kernel.crashing.org> (raw)
In-Reply-To: <20170403105434.60309d3e@kryten>
On Mon, 2017-04-03 at 10:54 +1000, Anton Blanchard wrote:
> > > Good idea, I hadn't thought of embedding it all in a feature
> > > section.
> >
> > It may not work currently because you get those ftr_alt_97 relocation
> > errors with the "else" parts because relative branches to other code
> > need to be direct and I think reachable from both places.
>
> I thought about this a bit more. One potential issue will be
> profiling - perf annotate will match the samples against the unpatched
> code which could be very confusing.
Could we make all those functions a dynamic-linker style stub ?
IE, they "find" the right target function and call a helper to patch
the calling site to call directly into the right one on the first
call.
Cheers,
Ben.
next prev parent reply other threads:[~2017-04-03 1:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-20 23:40 [PATCH] powerpc: Add POWER9 copy_page() loop Anton Blanchard
2017-03-21 3:01 ` Nicholas Piggin
2017-03-21 4:01 ` Anton Blanchard
2017-03-21 4:21 ` Nicholas Piggin
2017-04-03 0:54 ` Anton Blanchard
2017-04-03 1:01 ` Benjamin Herrenschmidt [this message]
2018-01-27 10:06 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1491181311.26047.23.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=anton@samba.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).