linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] powerpc/mm/hash: don't opencode VMALLOC_INDEX
@ 2017-04-12  4:40 Aneesh Kumar K.V
  2017-04-12  6:55 ` Michael Ellerman
  2017-04-19  3:47 ` Michael Ellerman
  0 siblings, 2 replies; 3+ messages in thread
From: Aneesh Kumar K.V @ 2017-04-12  4:40 UTC (permalink / raw)
  To: benh, paulus, mpe; +Cc: linuxppc-dev, Aneesh Kumar K.V

Also remove wrong indentation to fix checkpatch.pl warning.

Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
---
 arch/powerpc/mm/slb.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/powerpc/mm/slb.c b/arch/powerpc/mm/slb.c
index 98ae810b8c21..3d580ccf4b71 100644
--- a/arch/powerpc/mm/slb.c
+++ b/arch/powerpc/mm/slb.c
@@ -131,9 +131,9 @@ static void __slb_flush_and_rebolt(void)
 		     "slbmte	%2,%3\n"
 		     "isync"
 		     :: "r"(mk_vsid_data(VMALLOC_START, mmu_kernel_ssize, vflags)),
-		        "r"(mk_esid_data(VMALLOC_START, mmu_kernel_ssize, 1)),
-		        "r"(ksp_vsid_data),
-		        "r"(ksp_esid_data)
+			"r"(mk_esid_data(VMALLOC_START, mmu_kernel_ssize, VMALLOC_INDEX)),
+			"r"(ksp_vsid_data),
+			"r"(ksp_esid_data)
 		     : "memory");
 }
 
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] powerpc/mm/hash: don't opencode VMALLOC_INDEX
  2017-04-12  4:40 [PATCH] powerpc/mm/hash: don't opencode VMALLOC_INDEX Aneesh Kumar K.V
@ 2017-04-12  6:55 ` Michael Ellerman
  2017-04-19  3:47 ` Michael Ellerman
  1 sibling, 0 replies; 3+ messages in thread
From: Michael Ellerman @ 2017-04-12  6:55 UTC (permalink / raw)
  To: Aneesh Kumar K.V, benh, paulus; +Cc: linuxppc-dev, Aneesh Kumar K.V

"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> writes:

> powerpc/mm/hash: don't opencode VMALLOC_INDEX

OK.

> Also remove wrong indentation to fix checkpatch.pl warning.

No thanks :)

Or at least do it as a separate patch.

I'll fix it up this time.

cheers

> diff --git a/arch/powerpc/mm/slb.c b/arch/powerpc/mm/slb.c
> index 98ae810b8c21..3d580ccf4b71 100644
> --- a/arch/powerpc/mm/slb.c
> +++ b/arch/powerpc/mm/slb.c
> @@ -131,9 +131,9 @@ static void __slb_flush_and_rebolt(void)
>  		     "slbmte	%2,%3\n"
>  		     "isync"
>  		     :: "r"(mk_vsid_data(VMALLOC_START, mmu_kernel_ssize, vflags)),
> -		        "r"(mk_esid_data(VMALLOC_START, mmu_kernel_ssize, 1)),
> -		        "r"(ksp_vsid_data),
> -		        "r"(ksp_esid_data)
> +			"r"(mk_esid_data(VMALLOC_START, mmu_kernel_ssize, VMALLOC_INDEX)),
> +			"r"(ksp_vsid_data),
> +			"r"(ksp_esid_data)
>  		     : "memory");
>  }
>  
> -- 
> 2.7.4

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: powerpc/mm/hash: don't opencode VMALLOC_INDEX
  2017-04-12  4:40 [PATCH] powerpc/mm/hash: don't opencode VMALLOC_INDEX Aneesh Kumar K.V
  2017-04-12  6:55 ` Michael Ellerman
@ 2017-04-19  3:47 ` Michael Ellerman
  1 sibling, 0 replies; 3+ messages in thread
From: Michael Ellerman @ 2017-04-19  3:47 UTC (permalink / raw)
  To: Aneesh Kumar K.V, benh, paulus; +Cc: linuxppc-dev, Aneesh Kumar K.V

On Wed, 2017-04-12 at 04:40:22 UTC, "Aneesh Kumar K.V" wrote:
> Also remove wrong indentation to fix checkpatch.pl warning.
> 
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/5f8122611b35c563a7c907485aafd8

cheers

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-04-19  3:47 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-12  4:40 [PATCH] powerpc/mm/hash: don't opencode VMALLOC_INDEX Aneesh Kumar K.V
2017-04-12  6:55 ` Michael Ellerman
2017-04-19  3:47 ` Michael Ellerman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).