* [bug report] powerpc/xive: Native exploitation of the XIVE interrupt controller
@ 2017-04-20 1:20 Dan Carpenter
2017-04-20 1:28 ` Benjamin Herrenschmidt
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2017-04-20 1:20 UTC (permalink / raw)
To: benh; +Cc: linuxppc-dev
Hello Benjamin Herrenschmidt,
The patch 243e25112d06: "powerpc/xive: Native exploitation of the
XIVE interrupt controller" from Apr 5, 2017, leads to the following
static checker warning:
arch/powerpc/sysdev/xive/native.c:184 __xive_native_disable_queue()
info: ignoring unreachable code.
arch/powerpc/sysdev/xive/native.c
176 static void __xive_native_disable_queue(u32 vp_id, struct xive_q *q, u8 prio)
177 {
178 s64 rc;
179
180 /* Disable the queue in HW */
181 for (;;) {
182 rc = opal_xive_set_queue_info(vp_id, prio, 0, 0, 0);
183 break;
This should be "if (!rc) break;"
184 msleep(1);
185 }
186 if (rc)
But we need some kind of timeout to ever print this error message.
187 pr_err("Error %lld disabling queue for prio %d\n", rc, prio);
188 }
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [bug report] powerpc/xive: Native exploitation of the XIVE interrupt controller
2017-04-20 1:20 [bug report] powerpc/xive: Native exploitation of the XIVE interrupt controller Dan Carpenter
@ 2017-04-20 1:28 ` Benjamin Herrenschmidt
0 siblings, 0 replies; 2+ messages in thread
From: Benjamin Herrenschmidt @ 2017-04-20 1:28 UTC (permalink / raw)
To: Dan Carpenter; +Cc: linuxppc-dev
On Thu, 2017-04-20 at 04:20 +0300, Dan Carpenter wrote:
> Hello Benjamin Herrenschmidt,
>
> The patch 243e25112d06: "powerpc/xive: Native exploitation of the
> XIVE interrupt controller" from Apr 5, 2017, leads to the following
> static checker warning:
>
> arch/powerpc/sysdev/xive/native.c:184
> __xive_native_disable_queue()
> info: ignoring unreachable code.
>
> arch/powerpc/sysdev/xive/native.c
> 176 static void __xive_native_disable_queue(u32 vp_id, struct
> xive_q *q, u8 prio)
> 177 {
> 178 s64 rc;
> 179
> 180 /* Disable the queue in HW */
> 181 for (;;) {
> 182 rc = opal_xive_set_queue_info(vp_id, prio, 0,
> 0, 0);
> 183 break;
>
> This should be "if (!rc) break;"
Thanks, for some reason that line got accidentally dropped... oops.
>
> 184 msleep(1);
> 185 }
> 186 if (rc)
>
> But we need some kind of timeout to ever print this error message.
>
> 187 pr_err("Error %lld disabling queue for prio
> %d\n", rc, prio);
> 188 }
>
> regards,
> dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-04-20 1:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-20 1:20 [bug report] powerpc/xive: Native exploitation of the XIVE interrupt controller Dan Carpenter
2017-04-20 1:28 ` Benjamin Herrenschmidt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).