linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Nicholas Piggin <npiggin@gmail.com>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc/64s: use ibm,tlbiel-congruence-classes-(hash|radix) dt property
Date: Mon, 24 Apr 2017 10:13:23 +1000	[thread overview]
Message-ID: <1492992803.25766.193.camel@kernel.crashing.org> (raw)
In-Reply-To: <20170423195755.43e36953@roar.ozlabs.ibm.com>

On Sun, 2017-04-23 at 19:57 +1000, Nicholas Piggin wrote:
> On Sun, 23 Apr 2017 10:39:11 +1000
> Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> 
> > On Sun, 2017-04-23 at 09:14 +1000, Nicholas Piggin wrote:
> > > I think we were going to take another look at moving the setup
> > > code
> > > later, but I think that might wait until 4.13.  
> > 
> > Except without that we won't boot a post-P9 CPU right ? So we'll
> > end up
> > having to chase distros to backport it :-( Oh well...
> 
> Okay, well what if we just move the TLB flushing to somewhere like
> early_init_mmu(_secondary) for power CPUs first?
> 
> Non-local tlbie does not seem to have this requirement, so would it
> make it more robust just to execute that once during boot with the
> primary thread?

I wouldn't do a broadcast before we have LPCR setup... but for no
obvious reason. Also I'm not sure our boot time cleanup does things
properly vs hash & radix. I think we really need 2 passes.

Oh well..

My main worry is the fact that on future chip we won't be setting up
LPCR properly. We should at least assume an unknown chip is P9, is that
what you do with your cpu-features patches ?

Cheers,
Ben.

  reply	other threads:[~2017-04-24  0:13 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20170422005854.17128-1-npiggin@gmail.com>
2017-04-22  0:58 ` [PATCH] powerpc/64s: use ibm, tlbiel-congruence-classes-(hash|radix) dt property Nicholas Piggin
2017-04-22  8:02   ` [PATCH] powerpc/64s: use ibm,tlbiel-congruence-classes-(hash|radix) " Benjamin Herrenschmidt
2017-04-22 23:14     ` Nicholas Piggin
2017-04-23  0:39       ` Benjamin Herrenschmidt
2017-04-23  9:57         ` Nicholas Piggin
2017-04-24  0:13           ` Benjamin Herrenschmidt [this message]
2017-04-24  4:22             ` Nicholas Piggin
2017-04-30 10:59             ` Nicholas Piggin
2017-04-22 10:34   ` [PATCH] powerpc/64s: use ibm, tlbiel-congruence-classes-(hash|radix) " kbuild test robot
2017-04-24  8:23   ` Aneesh Kumar K.V
2017-04-24  9:17     ` Michael Ellerman
2017-04-24  9:22       ` Aneesh Kumar K.V
2017-04-26  8:29     ` [PATCH] powerpc/64s: use ibm,tlbiel-congruence-classes-(hash|radix) " Nicholas Piggin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1492992803.25766.193.camel@kernel.crashing.org \
    --to=benh@kernel.crashing.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=npiggin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).