From: "Alastair D'Silva" <alastair@au1.ibm.com>
To: Andrew Donnellan <andrew.donnellan@au1.ibm.com>, linuxppc-dev@ozlabs.org
Cc: frederic.barrat@fr.ibm.com
Subject: Re: [PATCH v2] cxl: Prevent IRQ storm
Date: Thu, 27 Apr 2017 14:47:43 +1000	[thread overview]
Message-ID: <1493268463.3426.23.camel@au1.ibm.com> (raw)
In-Reply-To: <19926571-7158-0ad8-4bf4-aa20abf23092@au1.ibm.com>
On Thu, 2017-04-27 at 14:41 +1000, Andrew Donnellan wrote:
On 27/04/17 11:37, Alastair D'Silva wrote:
> > From: Alastair D'Silva <alastair@d-silva.org>
> > 
> > In some situations, a faulty AFU slice may create an interrupt
> > storm,
> > rendering the machine unusable. Since these interrupts are
> > informational
> > only, present the interrupt once, then mask it off to prevent it
> > from
> > being retriggered until the card is reset.
> > 
> > Changelog:
> > v2
> > 	Rebase against linux-next
> 
> The patch changelog shouldn't be part of the commit message - it
> should 
> go under a "---" line after the sign-off so it doesn't get included
> in 
> the final commit.
> 
> Also now that I've taken a second look, I think the summary line of
> the 
> commit message could be more descriptive, something like:
> 
> "cxl: mask slice error interrupt after first occurrence"
> 
> or something to that effect?
> 
Ok
-- 
Alastair D'Silva
Open Source Developer
Linux Technology Centre, IBM Australia
mob: 0423 762 819
next prev parent reply	other threads:[~2017-04-27  4:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-27  1:37 [PATCH v2] cxl: Prevent IRQ storm Alastair D'Silva
2017-04-27  4:41 ` Andrew Donnellan
2017-04-27  4:47   ` Alastair D'Silva [this message]
2017-04-27 11:29   ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox
  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):
  git send-email \
    --in-reply-to=1493268463.3426.23.camel@au1.ibm.com \
    --to=alastair@au1.ibm.com \
    --cc=andrew.donnellan@au1.ibm.com \
    --cc=frederic.barrat@fr.ibm.com \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY
  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
  Be sure your reply has a Subject: header at the top and a blank line
  before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).