From: Pingfan Liu <piliu@redhat.com>
To: linuxppc-dev@lists.ozlabs.org
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Hari Bathini <hbathini@linux.vnet.ibm.com>,
kernelfans@gmail.com
Subject: [PATCH] powerpc/pseries hotplug: prevent the reserved mem from removing
Date: Thu, 27 Apr 2017 15:43:08 +0800 [thread overview]
Message-ID: <1493278988-26169-1-git-send-email-piliu@redhat.com> (raw)
E.g after fadump reserves mem regions, these regions should not be removed
before fadump explicitly free them.
Signed-off-by: Pingfan Liu <piliu@redhat.com>
---
arch/powerpc/platforms/pseries/hotplug-memory.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/platforms/pseries/hotplug-memory.c b/arch/powerpc/platforms/pseries/hotplug-memory.c
index e104c71..201be23 100644
--- a/arch/powerpc/platforms/pseries/hotplug-memory.c
+++ b/arch/powerpc/platforms/pseries/hotplug-memory.c
@@ -346,6 +346,8 @@ static int pseries_remove_memblock(unsigned long base, unsigned int memblock_siz
if (!pfn_valid(start_pfn))
goto out;
+ if (memblock_is_reserved(base))
+ return -EINVAL;
block_sz = pseries_memory_block_size();
sections_per_block = block_sz / MIN_MEMORY_BLOCK_SIZE;
@@ -388,8 +390,7 @@ static int pseries_remove_mem_node(struct device_node *np)
base = be64_to_cpu(*(unsigned long *)regs);
lmb_size = be32_to_cpu(regs[3]);
- pseries_remove_memblock(base, lmb_size);
- return 0;
+ return pseries_remove_memblock(base, lmb_size);
}
static bool lmb_is_removable(struct of_drconf_cell *lmb)
--
2.7.4
next reply other threads:[~2017-04-27 7:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-27 7:43 Pingfan Liu [this message]
2017-04-27 18:06 ` [PATCH] powerpc/pseries hotplug: prevent the reserved mem from removing Hari Bathini
2017-04-28 4:29 ` Liu ping fan
2017-05-02 18:37 ` Hari Bathini
2017-04-28 10:18 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1493278988-26169-1-git-send-email-piliu@redhat.com \
--to=piliu@redhat.com \
--cc=benh@kernel.crashing.org \
--cc=hbathini@linux.vnet.ibm.com \
--cc=kernelfans@gmail.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).