linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Ankit Kumar <ankit@linux.vnet.ibm.com>
To: keescook@chromium.org, anton@enomsg.org, ccross@android.com,
	tony.luck@intel.com, xinhui.pan@linux.vnet.ibm.com
Cc: benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au,
	andrew.donnellan@au1.ibm.com, dja@axtens.net,
	geliangtang@163.com, linuxppc-dev@lists.ozlabs.org,
	linux-kernel@vger.kernel.org, mahesh@linux.vnet.ibm.com,
	Ankit Kumar <ankit@linux.vnet.ibm.com>
Subject: [PATCH] Enabled pstore write for powerpc
Date: Thu, 27 Apr 2017 17:03:13 +0530	[thread overview]
Message-ID: <1493292794-13166-1-git-send-email-ankit@linux.vnet.ibm.com> (raw)

After commit c950fd6f201a kernel registers pstore write based on flag set.
Pstore write for powerpc is broken as flags(PSTORE_FLAGS_DMESG) is not set for
powerpc architecture. On panic, kernel doesn't write message to
/fs/pstore/dmesg*(Entry doesn't gets created at all).

This patch enables pstore write for powerpc architecture by setting
PSTORE_FLAGS_DMESG flag.

Fixes:c950fd6f201a pstore: Split pstore fragile flags
Signed-off-by: Ankit Kumar <ankit@linux.vnet.ibm.com>
---

 arch/powerpc/kernel/nvram_64.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/powerpc/kernel/nvram_64.c b/arch/powerpc/kernel/nvram_64.c
index d5e2b83..021db31 100644
--- a/arch/powerpc/kernel/nvram_64.c
+++ b/arch/powerpc/kernel/nvram_64.c
@@ -561,6 +561,7 @@ static ssize_t nvram_pstore_read(u64 *id, enum pstore_type_id *type,
 static struct pstore_info nvram_pstore_info = {
 	.owner = THIS_MODULE,
 	.name = "nvram",
+	.flags = PSTORE_FLAGS_DMESG,
 	.open = nvram_pstore_open,
 	.read = nvram_pstore_read,
 	.write = nvram_pstore_write,
-- 
2.7.4

             reply	other threads:[~2017-04-27 11:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-27 11:33 Ankit Kumar [this message]
2017-04-27 20:21 ` [PATCH] Enabled pstore write for powerpc Anton Blanchard
2017-04-27 21:38 ` Kees Cook
2017-04-28  2:57   ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1493292794-13166-1-git-send-email-ankit@linux.vnet.ibm.com \
    --to=ankit@linux.vnet.ibm.com \
    --cc=andrew.donnellan@au1.ibm.com \
    --cc=anton@enomsg.org \
    --cc=benh@kernel.crashing.org \
    --cc=ccross@android.com \
    --cc=dja@axtens.net \
    --cc=geliangtang@163.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mahesh@linux.vnet.ibm.com \
    --cc=mpe@ellerman.id.au \
    --cc=paulus@samba.org \
    --cc=tony.luck@intel.com \
    --cc=xinhui.pan@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).