From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Michael Ellerman <mpe@ellerman.id.au>, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] powerpc/xive: Fix/improve verbose debug output
Date: Fri, 28 Apr 2017 07:20:05 +0200 [thread overview]
Message-ID: <1493356805.25766.296.camel@kernel.crashing.org> (raw)
In-Reply-To: <87zif1p6vw.fsf@concordia.ellerman.id.au>
On Fri, 2017-04-28 at 13:07 +1000, Michael Ellerman wrote:
> Benjamin Herrenschmidt <benh@kernel.crashing.org> writes:
>
> > The existing verbose debug code doesn't build when enabled.
>
> So why don't we convert all the DBG_VERBOSE() to pr_devel()?
pr_devel provides a bunch of debug at init/setup/mask/unmask etc... but
the system is still usable
DBG_VERBOSE starts spewing stuff on every interrupt and eoi, the system
is no longer usable.
> If there's non-verbose debug that we think would be useful to
> differentiate from verbose then those could be pr_debug() - which means
> they'll be jump labelled off in most production kernels, but still able
> to be enabled.
Maybe... I don't like the giant "debug" switch accross the whole
kernel, though.
Ben.
next prev parent reply other threads:[~2017-04-28 5:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-27 13:57 [PATCH] powerpc/xive: Fix/improve verbose debug output Benjamin Herrenschmidt
2017-04-28 3:07 ` Michael Ellerman
2017-04-28 5:20 ` Benjamin Herrenschmidt [this message]
2017-04-28 6:34 ` Michael Ellerman
2017-04-28 6:48 ` Benjamin Herrenschmidt
2017-04-28 9:58 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1493356805.25766.296.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).