From: Scott Wood <oss@buserror.net>
To: schindele@nentec.de
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: Freescale mpc8315 IRQ0 setup
Date: Thu, 04 May 2017 15:55:28 -0500 [thread overview]
Message-ID: <1493931328.25397.35.camel@buserror.net> (raw)
In-Reply-To: <41499955.CTp69um5pn@sherry>
On Thu, 2017-05-04 at 17:06 +0200, Juergen Schindele wrote:
> Am Dienstag, 2. Mai 2017, 22:29:34 schrieb Scott Wood:
> > On Tue, 2017-05-02 at 14:43 +0200, Juergen Schindele wrote:
> > > Dear Scott,
> > > sorry for the delay but i am not very familiar with the formating.
> > > I passed the patch trough checkpatch.pl and there was no more error.
> > > pease find patch in attached file.
> > > Thanks
> >
> > Documentation/process/submitting-patches.rst explains the way to format
> > and
> > submit kernel patches.
> >
> > Also, why the unrelated change to a print statement in
> > ipic_set_irq_type()?
> >
> > -Scott
>
> The second diff is not completely unrelated because when i was
> investigating
> the problem i saw only a message "edge sense not supported" but you dont
> know on which interrupt he is complaining about. So i added this to find
> out
> who the suspect is.
That's fine but it's still fixing a different problem than "irq0 setup" and
should be a separate patch.
> Corrected patch
Again, please read Documentation/process/submitting-patches.rst. Patches
should be inline, not attached. The subject line should be something like
"powerpc/ipic: Configure "EDGE" capabilities for IRQ0 (like IRQ1-7)" and there
should be more description in the body of the changelog.
-Scott
next prev parent reply other threads:[~2017-05-04 20:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-10 14:53 Freescale mpc8315 IRQ0 setup Juergen Schindele
2017-04-30 6:55 ` Scott Wood
2017-05-02 12:43 ` Juergen Schindele
2017-05-03 3:29 ` Scott Wood
2017-05-04 15:06 ` Juergen Schindele
2017-05-04 20:55 ` Scott Wood [this message]
2017-05-11 12:34 ` [PATCH] Freescale mpc8315 interrupt chip Juergen Schindele
2017-05-11 13:38 ` Oliver O'Halloran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1493931328.25397.35.camel@buserror.net \
--to=oss@buserror.net \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=schindele@nentec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).