From: Balbir Singh <bsingharora@gmail.com>
To: LEROY Christophe <christophe.leroy@c-s.fr>
Cc: naveen.n.rao@linux.vnet.ibm.com, mpe@ellerman.id.au,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [RFC 0/2] Consolidate patch_instruction
Date: Wed, 17 May 2017 12:10:32 +1000 [thread overview]
Message-ID: <1494987032.30802.6.camel@gmail.com> (raw)
In-Reply-To: <20170516222015.Horde.fwWhnIwI59SuB64Du97wdg2@messagerie.c-s.fr>
On Tue, 2017-05-16 at 22:20 +0200, LEROY Christophe wrote:
> Balbir Singh <bsingharora@gmail.com> a écrit :
>
> > patch_instruction is enhanced in this RFC to support
> > patching via a different virtual address (text_poke_area).
> > The mapping of text_poke_area->addr is RW and not RWX.
> > This way the mapping allows write for patching and then we tear
> > down the mapping. The downside is that we introduce a spinlock
> > which serializes our patching to one patch at a time.
>
> Very nice patch, would fit great with my patch for impmementing
> CONFIG_DEBUG_RODATA (https://patchwork.ozlabs.org/patch/754289 ).
> Would avoid having to set the text area back to RW for patching
>
Awesome! It seems like you have some of the work for CONFIG_STRICT_KERNEL_RWX
any reason why this is under CONFIG_DEBUG_RODATA? But I think there is
reuse capability across the future patches and the current set.
Cheers,
Balbir Singh.
next prev parent reply other threads:[~2017-05-17 2:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-16 3:49 [RFC 0/2] Consolidate patch_instruction Balbir Singh
2017-05-16 3:49 ` [RFC 1/2] powerpc/lib/code-patching: Enhance code patching Balbir Singh
2017-05-16 3:49 ` [RFC 2/2] powerpc/kprobes: Move kprobes over to patch_instruction Balbir Singh
2017-05-16 13:35 ` Naveen N. Rao
2017-05-17 1:40 ` Balbir Singh
2017-05-30 14:28 ` Naveen N. Rao
2017-05-16 5:26 ` [RFC 0/2] Consolidate patch_instruction Anshuman Khandual
2017-05-16 13:41 ` Naveen N. Rao
2017-05-17 1:23 ` Balbir Singh
2017-05-16 20:20 ` LEROY Christophe
2017-05-17 2:10 ` Balbir Singh [this message]
2017-05-17 7:04 ` LEROY Christophe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1494987032.30802.6.camel@gmail.com \
--to=bsingharora@gmail.com \
--cc=christophe.leroy@c-s.fr \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=naveen.n.rao@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).