linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: powerpc/opal-irqchip: Use interrupt names if present
Date: Sat, 03 Jun 2017 00:11:42 +1000	[thread overview]
Message-ID: <1496412702.2842.11.camel@kernel.crashing.org> (raw)
In-Reply-To: <CAMuHMdWGZYkM_aQ=vXr5J9-KFGzzWgq3hf+ZRY-n-+8-ghG5nQ@mail.gmail.com>

On Fri, 2017-06-02 at 14:39 +0200, Geert Uytterhoeven wrote:
> 
> > diff --git a/arch/powerpc/platforms/powernv/opal-irqchip.c b/arch/powerpc/platforms/powernv/opal-irqchip.c
> > index 998316bf2dad..ecdcba9d1220 100644
> > --- a/arch/powerpc/platforms/powernv/opal-irqchip.c
> > +++ b/arch/powerpc/platforms/powernv/opal-irqchip.c
> > @@ -183,8 +183,9 @@ void opal_event_shutdown(void)
> > +       /* It's not an error for the names to be missing */
> > +       of_property_read_string_array(opal_node, "opal-interrupts-names",
> > +                                     names, opal_irq_count);
> 
> Just double-checking, as it's different from the standard "interrupt-names":
> is "opal-interrupts-names" the correct name?

Yes, because the property it refers to isn't a standard "interrupts"
property... it's ... complicated :-)

It could have been mind you, but the decision for that was made years
ago... it's a bunch of interrupts OPAL is interested in, which Linux
requests and sets up a handler for which just calls back into OPAL. 

In any case, firmwares with that property are out now.

Cheers,
Ben.

  reply	other threads:[~2017-06-02 14:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20170222190235.92E5F661CEB@gitolite.kernel.org>
2017-06-02 12:39 ` powerpc/opal-irqchip: Use interrupt names if present Geert Uytterhoeven
2017-06-02 14:11   ` Benjamin Herrenschmidt [this message]
2017-06-03 14:04     ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1496412702.2842.11.camel@kernel.crashing.org \
    --to=benh@kernel.crashing.org \
    --cc=devicetree@vger.kernel.org \
    --cc=geert@linux-m68k.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).