* Re: powerpc/opal-irqchip: Use interrupt names if present [not found] <20170222190235.92E5F661CEB@gitolite.kernel.org> @ 2017-06-02 12:39 ` Geert Uytterhoeven 2017-06-02 14:11 ` Benjamin Herrenschmidt 0 siblings, 1 reply; 3+ messages in thread From: Geert Uytterhoeven @ 2017-06-02 12:39 UTC (permalink / raw) To: Benjamin Herrenschmidt Cc: linuxppc-dev@lists.ozlabs.org, devicetree@vger.kernel.org Hi Ben, On Wed, Feb 22, 2017 at 8:02 PM, Linux Kernel Mailing List <linux-kernel@vger.kernel.org> wrote: > Web: https://git.kernel.org/torvalds/c/2717a33d60745f2f72e521cdaedf79b00f66f8ca > Commit: 2717a33d60745f2f72e521cdaedf79b00f66f8ca > Parent: 470a36a8c014e5cac7bb2df382948597f7ec1b2c > Refname: refs/heads/master > Author: Benjamin Herrenschmidt <benh@kernel.crashing.org> > AuthorDate: Mon Feb 6 16:07:36 2017 +1100 > Committer: Michael Ellerman <mpe@ellerman.id.au> > CommitDate: Thu Feb 9 10:31:37 2017 +1100 > > powerpc/opal-irqchip: Use interrupt names if present > > Recent versions of OPAL can provide names for the various OPAL interrupts, > so let's use them. This also modernises the code that fetches the > interrupt array to use the helpers provided by the generic code instead > of hand-parsing the property. > > Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> > [mpe: Free irqs on error, check allocation of names, consolidate error > handling, whitespace.] > Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> > --- > arch/powerpc/platforms/powernv/opal-irqchip.c | 55 ++++++++++++++++++++------- > 1 file changed, 42 insertions(+), 13 deletions(-) > > diff --git a/arch/powerpc/platforms/powernv/opal-irqchip.c b/arch/powerpc/platforms/powernv/opal-irqchip.c > index 998316bf2dad..ecdcba9d1220 100644 > --- a/arch/powerpc/platforms/powernv/opal-irqchip.c > +++ b/arch/powerpc/platforms/powernv/opal-irqchip.c > @@ -183,8 +183,9 @@ void opal_event_shutdown(void) > + /* It's not an error for the names to be missing */ > + of_property_read_string_array(opal_node, "opal-interrupts-names", > + names, opal_irq_count); Just double-checking, as it's different from the standard "interrupt-names": is "opal-interrupts-names" the correct name? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: powerpc/opal-irqchip: Use interrupt names if present 2017-06-02 12:39 ` powerpc/opal-irqchip: Use interrupt names if present Geert Uytterhoeven @ 2017-06-02 14:11 ` Benjamin Herrenschmidt 2017-06-03 14:04 ` Geert Uytterhoeven 0 siblings, 1 reply; 3+ messages in thread From: Benjamin Herrenschmidt @ 2017-06-02 14:11 UTC (permalink / raw) To: Geert Uytterhoeven Cc: linuxppc-dev@lists.ozlabs.org, devicetree@vger.kernel.org On Fri, 2017-06-02 at 14:39 +0200, Geert Uytterhoeven wrote: > > > diff --git a/arch/powerpc/platforms/powernv/opal-irqchip.c b/arch/powerpc/platforms/powernv/opal-irqchip.c > > index 998316bf2dad..ecdcba9d1220 100644 > > --- a/arch/powerpc/platforms/powernv/opal-irqchip.c > > +++ b/arch/powerpc/platforms/powernv/opal-irqchip.c > > @@ -183,8 +183,9 @@ void opal_event_shutdown(void) > > + /* It's not an error for the names to be missing */ > > + of_property_read_string_array(opal_node, "opal-interrupts-names", > > + names, opal_irq_count); > > Just double-checking, as it's different from the standard "interrupt-names": > is "opal-interrupts-names" the correct name? Yes, because the property it refers to isn't a standard "interrupts" property... it's ... complicated :-) It could have been mind you, but the decision for that was made years ago... it's a bunch of interrupts OPAL is interested in, which Linux requests and sets up a handler for which just calls back into OPAL. In any case, firmwares with that property are out now. Cheers, Ben. ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: powerpc/opal-irqchip: Use interrupt names if present 2017-06-02 14:11 ` Benjamin Herrenschmidt @ 2017-06-03 14:04 ` Geert Uytterhoeven 0 siblings, 0 replies; 3+ messages in thread From: Geert Uytterhoeven @ 2017-06-03 14:04 UTC (permalink / raw) To: Benjamin Herrenschmidt Cc: linuxppc-dev@lists.ozlabs.org, devicetree@vger.kernel.org Hi Ben, On Fri, Jun 2, 2017 at 4:11 PM, Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote: > On Fri, 2017-06-02 at 14:39 +0200, Geert Uytterhoeven wrote: >> > diff --git a/arch/powerpc/platforms/powernv/opal-irqchip.c b/arch/powerpc/platforms/powernv/opal-irqchip.c >> > index 998316bf2dad..ecdcba9d1220 100644 >> > --- a/arch/powerpc/platforms/powernv/opal-irqchip.c >> > +++ b/arch/powerpc/platforms/powernv/opal-irqchip.c >> > @@ -183,8 +183,9 @@ void opal_event_shutdown(void) >> > + /* It's not an error for the names to be missing */ >> > + of_property_read_string_array(opal_node, "opal-interrupts-names", >> > + names, opal_irq_count); >> >> Just double-checking, as it's different from the standard "interrupt-names": >> is "opal-interrupts-names" the correct name? > > Yes, because the property it refers to isn't a standard "interrupts" > property... it's ... complicated :-) I'm aware it's a different property. > It could have been mind you, but the decision for that was made years > ago... it's a bunch of interrupts OPAL is interested in, which Linux > requests and sets up a handler for which just calls back into OPAL. > > In any case, firmwares with that property are out now. Thanks for the confirmation! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-06-03 14:04 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- [not found] <20170222190235.92E5F661CEB@gitolite.kernel.org> 2017-06-02 12:39 ` powerpc/opal-irqchip: Use interrupt names if present Geert Uytterhoeven 2017-06-02 14:11 ` Benjamin Herrenschmidt 2017-06-03 14:04 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).