From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Michael Ellerman <patch-notifications@ellerman.id.au>,
Christophe Leroy <christophe.leroy@c-s.fr>,
Paul Mackerras <paulus@samba.org>, Scott Wood <oss@buserror.net>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [v2] powerpc: handle simultaneous interrupts at once
Date: Mon, 05 Jun 2017 21:17:04 +1000 [thread overview]
Message-ID: <1496661424.31588.1.camel@kernel.crashing.org> (raw)
In-Reply-To: <3wh9ph0pv2z9s7f@ozlabs.org>
On Mon, 2017-06-05 at 20:21 +1000, Michael Ellerman wrote:
> On Thu, 2017-03-16 at 08:55:45 UTC, Christophe Leroy wrote:
> > It often happens to have simultaneous interrupts, for instance
> > when having double Ethernet attachment. With the current
> > implementation, we suffer the cost of kernel entry/exit for each
> > interrupt.
> >
> > This patch introduces a loop in __do_irq() to handle all interrupts
> > at once before returning.
> >
> > Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
>
> Applied to powerpc next, thanks.
>
> https://git.kernel.org/powerpc/c/45cb08f4791ce6a15c54598b4cb73d
Hrm, I hadn't noticed that patch...
We used to do that and then removed the code for it. There's a cost,
sometimes noticeable, to an extra call to ppc_md.get_irq.
Why not have your get_irq (or eoi) implementation set a per-cpu
requesting a new spin of the loop ?
We could move the xive force replay stuff to use the same thing.
Ben.
prev parent reply other threads:[~2017-06-05 11:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-16 8:55 [PATCH v2] powerpc: handle simultaneous interrupts at once Christophe Leroy
2017-06-05 10:21 ` [v2] " Michael Ellerman
2017-06-05 11:17 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1496661424.31588.1.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=christophe.leroy@c-s.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=oss@buserror.net \
--cc=patch-notifications@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).