linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Michael Neuling <mikey@neuling.org>
To: Michael Ellerman <mpe@ellerman.id.au>, linuxppc-dev@lists.ozlabs.org
Cc: benh@kernel.crashing.org, paulus@samba.org, sam.bobroff@au1.ibm.com
Subject: Re: [PATCH] powernv: Properly mask POWER9 DD1 PVR for different chip types
Date: Thu, 08 Jun 2017 10:44:10 +1000	[thread overview]
Message-ID: <1496882650.31524.14.camel@neuling.org> (raw)
In-Reply-To: <87efuwp8ef.fsf@concordia.ellerman.id.au>

On Wed, 2017-06-07 at 17:24 +1000, Michael Ellerman wrote:
> Michael Neuling <mikey@neuling.org> writes:
>=20
> > Bits 48:51 in the PVR for POWER9 represent different chip types (scale
> > up vs out and 12 vs 24 core). Current chips have 0 here, but could be
> > non-zero in the future.
> >=20
> > This changes the POWER9 DD1 mask to correctly ignore these bits 48:51.
> >=20
> > Signed-off-by: Michael Neuling <mikey@neuling.org>
> > ---
> > =C2=A0arch/powerpc/kernel/cputable.c | 4 ++--
> > =C2=A01 file changed, 2 insertions(+), 2 deletions(-)
>=20
> Presumably we should backport this?

Actually, we need to scrap this patch.

Looks like the scale up version will be marked as DD1, but it won't need th=
ese
workarounds. So we need it to match on the other POWER9 entry.

Mikey

>=20
> cheers
>=20
> > diff --git a/arch/powerpc/kernel/cputable.c b/arch/powerpc/kernel/cputa=
ble.c
> > index 9b3e88b1a9..89dcd94237 100644
> > --- a/arch/powerpc/kernel/cputable.c
> > +++ b/arch/powerpc/kernel/cputable.c
> > @@ -526,8 +526,8 @@ static struct cpu_spec __initdata cpu_specs[] =3D {
> > =C2=A0		.machine_check_early	=3D
> > __machine_check_early_realmode_p8,
> > =C2=A0		.platform		=3D "power8",
> > =C2=A0	},
> > -	{	/* Power9 DD1*/
> > -		.pvr_mask		=3D 0xffffff00,
> > +	{	/* Power9 DD1. Bits 48:51 represent chip type so mask
> > these */
> > +		.pvr_mask		=3D 0xffff0f00,
> > =C2=A0		.pvr_value		=3D 0x004e0100,
> > =C2=A0		.cpu_name		=3D "POWER9 (raw)",
> > =C2=A0		.cpu_features		=3D CPU_FTRS_POWER9_DD1,
> > --=C2=A0
> > 2.11.0
>=20
>=20

  reply	other threads:[~2017-06-08  0:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-07  4:11 [PATCH] powernv: Properly mask POWER9 DD1 PVR for different chip types Michael Neuling
2017-06-07  7:24 ` Michael Ellerman
2017-06-08  0:44   ` Michael Neuling [this message]
2017-06-08  3:44     ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1496882650.31524.14.camel@neuling.org \
    --to=mikey@neuling.org \
    --cc=benh@kernel.crashing.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=paulus@samba.org \
    --cc=sam.bobroff@au1.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).