From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Michael Ellerman <mpe@ellerman.id.au>,
Alexey Kardashevskiy <aik@ozlabs.ru>,
linuxppc-dev@lists.ozlabs.org
Cc: kvm@vger.kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org,
Gavin Shan <gwshan@linux.vnet.ibm.com>,
Yongji Xie <elohimes@gmail.com>,
Alex Williamson <alex.williamson@redhat.com>,
Paul Mackerras <paulus@samba.org>,
Yongji Xie <xyjxie@linux.vnet.ibm.com>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH kernel 2/3] pci-ioda: Set PCI_BUS_FLAGS_MSI_REMAP for IODA host bridge
Date: Thu, 15 Jun 2017 20:56:15 +1000 [thread overview]
Message-ID: <1497524175.2897.75.camel@kernel.crashing.org> (raw)
In-Reply-To: <877f0dppql.fsf@concordia.ellerman.id.au>
On Thu, 2017-06-15 at 19:25 +1000, Michael Ellerman wrote:
> Alexey Kardashevskiy <aik@ozlabs.ru> writes:
>
> > From: Yongji Xie <elohimes@gmail.com>
> >
> > Any IODA host bridge have the capability of IRQ remapping.
> > So we set PCI_BUS_FLAGS_MSI_REMAP when this kind of host birdge
> > is detected.
>
> Where's the code that actually enforces this property?
>
> It would be good to have a comment in pnv_pci_ioda_root_bridge_prepare()
> (probably), pointing to that code, so that we can remember the
> relationship between the two.
Actually it's not so much remapping as:
- The bridge can enforce that the interrupt is allowed for a given
partition
- Because the interrupts are handled via the hypervisor, the latter
can do the remapping.
But the effect is the same, so yes we want the flag. On P9 with XIVE
exploitation we also have HW remapping on top.
Cheers,
Ben.
next prev parent reply other threads:[~2017-06-15 10:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-15 5:48 [PATCH kernel 0/3 REPOST] vfio-pci: Add support for mmapping MSI-X table Alexey Kardashevskiy
2017-06-15 5:48 ` [PATCH kernel 1/3] PCI: Add a new PCI_BUS_FLAGS_MSI_REMAP flag Alexey Kardashevskiy
2017-06-15 5:48 ` [PATCH kernel 2/3] pci-ioda: Set PCI_BUS_FLAGS_MSI_REMAP for IODA host bridge Alexey Kardashevskiy
2017-06-15 9:25 ` Michael Ellerman
2017-06-15 10:56 ` Benjamin Herrenschmidt [this message]
2017-06-15 5:48 ` [PATCH kernel 3/3] vfio-pci: Allow to expose MSI-X table to userspace if interrupt remapping is enabled Alexey Kardashevskiy
2017-06-22 21:11 ` [PATCH kernel 0/3 REPOST] vfio-pci: Add support for mmapping MSI-X table Alex Williamson
2017-06-23 5:06 ` Alexey Kardashevskiy
2017-06-23 15:17 ` Alex Williamson
2017-06-28 7:27 ` Alexey Kardashevskiy
2017-06-29 20:06 ` Alex Williamson
-- strict thread matches above, loose matches on Subject: below --
2017-06-15 5:06 [PATCH kernel 0/3] " Alexey Kardashevskiy
2017-06-15 5:06 ` [PATCH kernel 2/3] pci-ioda: Set PCI_BUS_FLAGS_MSI_REMAP for IODA host bridge Alexey Kardashevskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1497524175.2897.75.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=aik@ozlabs.ru \
--cc=alex.williamson@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=elohimes@gmail.com \
--cc=gwshan@linux.vnet.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=xyjxie@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).