From: frowand.list@gmail.com
To: Rob Herring <robh+dt@kernel.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org
Subject: [PATCH v6 0/4] of: remove *phandle properties from expanded device tree
Date: Tue, 20 Jun 2017 15:02:48 -0700 [thread overview]
Message-ID: <1497996172-821-1-git-send-email-frowand.list@gmail.com> (raw)
From: Frank Rowand <frank.rowand@sony.com>
Remove "phandle" and "linux,phandle" properties from the internal
device tree. The phandle will still be in the struct device_node
phandle field and will still be displayed as if it is a property
in /proc/device_tree.
This is to resolve the issue found by Stephen Boyd [1] when he changed
the type of struct property.value from void * to const void *. As
a result of the type change, the overlay code had compile errors
where the resolver updates phandle values.
[1] http://lkml.iu.edu/hypermail/linux/kernel/1702.1/04160.html
Patch 1 is the phandle related changes.
Patches 2 - 4 are minor fixups for issues that became visible
while implementing patch 1.
Changes from v5:
- patch 1: populate_properties(), prop_is_phandle was declared
at the wrong scope and thus was initialized before the for
loop instead of each time through the loop. This resulted
in any property in a node after the phandle property not
being unflattened.
Changes from v4:
- rebase on 4.12-rc1
- Add reason for "<NULL>" in of_attach_node()
- Simplify and consolidate phandle detection logic in
populate_properties(). This results in a change of behaviour,
the value of property "ibm,phandle" will no longer override the
value of properties "phandle" and "linux,phandle".
Changes from v3:
- patch 1: fix incorrect variable name in __of_add_phandle_sysfs().
Problem was reported by the kbuild test robot
Changes from v2:
- patch 1: Remove check in __of_add_phandle_sysfs() that would not
add a sysfs entry if IS_ENABLED(CONFIG_PPC_PSERIES)
Changes from v1:
- Remove phandle properties in of_attach_node(), before attaching
the node to the live tree.
- Add the phandle sysfs entry for the node in of_attach_node().
- When creating an overlay changeset, duplicate the node phandle in
__of_node_dup().
*** BLURB HERE ***
Frank Rowand (4):
of: remove *phandle properties from expanded device tree
of: make __of_attach_node() static
of: be consistent in form of file mode
of: detect invalid phandle in overlay
drivers/of/base.c | 50 +++++++++++++++++++++++++++++++++++++++----
drivers/of/dynamic.c | 57 +++++++++++++++++++++++++++++++++++++------------
drivers/of/fdt.c | 43 ++++++++++++++++++-------------------
drivers/of/of_private.h | 2 +-
drivers/of/overlay.c | 8 ++++---
drivers/of/resolver.c | 23 +-------------------
include/linux/of.h | 1 +
7 files changed, 118 insertions(+), 66 deletions(-)
--
Frank Rowand <frank.rowand@sony.com>
next reply other threads:[~2017-06-20 22:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-20 22:02 frowand.list [this message]
2017-06-20 22:02 ` [PATCH v6 1/4] of: remove *phandle properties from expanded device tree frowand.list
2017-06-21 4:57 ` Michael Ellerman
2017-06-21 6:18 ` Frank Rowand
2017-06-21 19:25 ` Frank Rowand
2017-06-21 23:56 ` Frank Rowand
2017-06-22 15:54 ` Rob Herring
2017-08-02 18:16 ` Frank Rowand
2017-06-20 22:02 ` [PATCH v6 2/4] of: make __of_attach_node() static frowand.list
2017-06-21 23:46 ` Stephen Boyd
2017-06-20 22:02 ` [PATCH v6 3/4] of: be consistent in form of file mode frowand.list
2017-06-20 22:02 ` [PATCH v6 4/4] of: detect invalid phandle in overlay frowand.list
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1497996172-821-1-git-send-email-frowand.list@gmail.com \
--to=frowand.list@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).