* [PATCH] qe: fix compile issue for arm64
@ 2017-07-21 2:19 Zhao Qiang
2017-07-21 6:34 ` Michael Ellerman
0 siblings, 1 reply; 4+ messages in thread
From: Zhao Qiang @ 2017-07-21 2:19 UTC (permalink / raw)
To: oss; +Cc: valentin.longchamp, linuxppc-dev, linux-kernel, Zhao Qiang
Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
---
drivers/soc/fsl/qe/qe.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/soc/fsl/qe/qe.c b/drivers/soc/fsl/qe/qe.c
index 2ef6fc6..d48fa4a 100644
--- a/drivers/soc/fsl/qe/qe.c
+++ b/drivers/soc/fsl/qe/qe.c
@@ -229,7 +229,9 @@ int qe_setbrg(enum qe_clock brg, unsigned int rate, unsigned int multiplier)
/* Errata QE_General4, which affects some MPC832x and MPC836x SOCs, says
that the BRG divisor must be even if you're not using divide-by-16
mode. */
+#ifdef CONFIG_PPC
if (pvr_version_is(PVR_VER_836x) || pvr_version_is(PVR_VER_832x))
+#endif
if (!div16 && (divisor & 1) && (divisor > 3))
divisor++;
--
2.1.0.27.g96db324
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] qe: fix compile issue for arm64
2017-07-21 2:19 [PATCH] qe: fix compile issue for arm64 Zhao Qiang
@ 2017-07-21 6:34 ` Michael Ellerman
2017-07-24 2:09 ` Qiang Zhao
0 siblings, 1 reply; 4+ messages in thread
From: Michael Ellerman @ 2017-07-21 6:34 UTC (permalink / raw)
To: Zhao Qiang, oss
Cc: valentin.longchamp, linuxppc-dev, linux-kernel, Zhao Qiang
Zhao Qiang <qiang.zhao@nxp.com> writes:
> Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
> ---
> drivers/soc/fsl/qe/qe.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/soc/fsl/qe/qe.c b/drivers/soc/fsl/qe/qe.c
> index 2ef6fc6..d48fa4a 100644
> --- a/drivers/soc/fsl/qe/qe.c
> +++ b/drivers/soc/fsl/qe/qe.c
> @@ -229,7 +229,9 @@ int qe_setbrg(enum qe_clock brg, unsigned int rate, unsigned int multiplier)
> /* Errata QE_General4, which affects some MPC832x and MPC836x SOCs, says
> that the BRG divisor must be even if you're not using divide-by-16
> mode. */
> +#ifdef CONFIG_PPC
> if (pvr_version_is(PVR_VER_836x) || pvr_version_is(PVR_VER_832x))
> +#endif
> if (!div16 && (divisor & 1) && (divisor > 3))
> divisor++;
Are you sure that's what you want to do on arm64 ?
cheers
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] qe: fix compile issue for arm64
2017-07-21 6:34 ` Michael Ellerman
@ 2017-07-24 2:09 ` Qiang Zhao
2017-07-24 3:32 ` Scott Wood
0 siblings, 1 reply; 4+ messages in thread
From: Qiang Zhao @ 2017-07-24 2:09 UTC (permalink / raw)
To: Michael Ellerman, oss@buserror.net
Cc: valentin.longchamp@keymile.com, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org
On Fri, 2017-07-21 at 02:34PM, Michael Ellerman <mpe@ellerman.id.au> wrote:
> -----Original Message-----
> From: Michael Ellerman [mailto:mpe@ellerman.id.au]
> Sent: Friday, July 21, 2017 2:34 PM
> To: Qiang Zhao <qiang.zhao@nxp.com>; oss@buserror.net
> Cc: valentin.longchamp@keymile.com; linuxppc-dev@lists.ozlabs.org; linux-
> kernel@vger.kernel.org; Qiang Zhao <qiang.zhao@nxp.com>
> Subject: Re: [PATCH] qe: fix compile issue for arm64
>=20
> Zhao Qiang <qiang.zhao@nxp.com> writes:
>=20
> > Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
> > ---
> > drivers/soc/fsl/qe/qe.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/soc/fsl/qe/qe.c b/drivers/soc/fsl/qe/qe.c index
> > 2ef6fc6..d48fa4a 100644
> > --- a/drivers/soc/fsl/qe/qe.c
> > +++ b/drivers/soc/fsl/qe/qe.c
> > @@ -229,7 +229,9 @@ int qe_setbrg(enum qe_clock brg, unsigned int rate,
> unsigned int multiplier)
> > /* Errata QE_General4, which affects some MPC832x and MPC836x
> SOCs, says
> > that the BRG divisor must be even if you're not using divide-by-16
> > mode. */
> > +#ifdef CONFIG_PPC
> > if (pvr_version_is(PVR_VER_836x) || pvr_version_is(PVR_VER_832x)
> > +#endif
> > if (!div16 && (divisor & 1) && (divisor > 3))
> > divisor++;
>=20
> Are you sure that's what you want to do on arm64 ?
Is there any problem?
Best Regards
Qiang Zhao
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] qe: fix compile issue for arm64
2017-07-24 2:09 ` Qiang Zhao
@ 2017-07-24 3:32 ` Scott Wood
0 siblings, 0 replies; 4+ messages in thread
From: Scott Wood @ 2017-07-24 3:32 UTC (permalink / raw)
To: Qiang Zhao, Michael Ellerman
Cc: valentin.longchamp@keymile.com, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org
On Mon, 2017-07-24 at 02:09 +0000, Qiang Zhao wrote:
> On Fri, 2017-07-21 at 02:34PM, Michael Ellerman <mpe@ellerman.id.au> wrote:
>
> > -----Original Message-----
> > From: Michael Ellerman [mailto:mpe@ellerman.id.au]
> > Sent: Friday, July 21, 2017 2:34 PM
> > To: Qiang Zhao <qiang.zhao@nxp.com>; oss@buserror.net
> > Cc: valentin.longchamp@keymile.com; linuxppc-dev@lists.ozlabs.org; linux-
> > kernel@vger.kernel.org; Qiang Zhao <qiang.zhao@nxp.com>
> > Subject: Re: [PATCH] qe: fix compile issue for arm64
> >
> > Zhao Qiang <qiang.zhao@nxp.com> writes:
> >
> > > Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
> > > ---
> > > drivers/soc/fsl/qe/qe.c | 2 ++
> > > 1 file changed, 2 insertions(+)
> > >
> > > diff --git a/drivers/soc/fsl/qe/qe.c b/drivers/soc/fsl/qe/qe.c index
> > > 2ef6fc6..d48fa4a 100644
> > > --- a/drivers/soc/fsl/qe/qe.c
> > > +++ b/drivers/soc/fsl/qe/qe.c
> > > @@ -229,7 +229,9 @@ int qe_setbrg(enum qe_clock brg, unsigned int rate,
> >
> > unsigned int multiplier)
> > > /* Errata QE_General4, which affects some MPC832x and MPC836x
> >
> > SOCs, says
> > > that the BRG divisor must be even if you're not using
> > > divide-by-16
> > > mode. */
> > > +#ifdef CONFIG_PPC
> > > if (pvr_version_is(PVR_VER_836x) ||
> > > pvr_version_is(PVR_VER_832x)
> > > +#endif
> > > if (!div16 && (divisor & 1) && (divisor > 3))
> > > divisor++;
> >
> > Are you sure that's what you want to do on arm64 ?
>
> Is there any problem?
>
> Best Regards
> Qiang Zhao
The comment says the workaround applies to MPC832x and MPC836x, but you're
applying the workaround on arm64 as well.
-Scott
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-07-24 3:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-21 2:19 [PATCH] qe: fix compile issue for arm64 Zhao Qiang
2017-07-21 6:34 ` Michael Ellerman
2017-07-24 2:09 ` Qiang Zhao
2017-07-24 3:32 ` Scott Wood
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).