linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Michael Ellerman <mpe@ellerman.id.au>
To: linuxppc-dev@ozlabs.org
Cc: anton@samba.org, aneesh.kumar@linux.vnet.ibm.com
Subject: [PATCH 2/3] powerpc/mm/slb: Move comment next to the code it's referring to
Date: Tue,  1 Aug 2017 20:29:23 +1000	[thread overview]
Message-ID: <1501583364-14909-2-git-send-email-mpe@ellerman.id.au> (raw)
In-Reply-To: <1501583364-14909-1-git-send-email-mpe@ellerman.id.au>

There is a comment in slb_allocate() referring to the load of
paca->vmalloc_sllp, but it's several lines prior in the assembly.
We're about to change this code, and we want to add another comment,
so move the comment immediately prior to the instruction it's talking
about.

Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
---
 arch/powerpc/mm/slb_low.S | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/arch/powerpc/mm/slb_low.S b/arch/powerpc/mm/slb_low.S
index bde378559d01..2eb1b92a68ff 100644
--- a/arch/powerpc/mm/slb_low.S
+++ b/arch/powerpc/mm/slb_low.S
@@ -121,12 +121,13 @@ slb_miss_kernel_load_vmemmap:
 1:
 #endif /* CONFIG_SPARSEMEM_VMEMMAP */
 
-	/* vmalloc mapping gets the encoding from the PACA as the mapping
-	 * can be demoted from 64K -> 4K dynamically on some machines
-	 */
 	clrldi	r11,r10,48
 	cmpldi	r11,(H_VMALLOC_SIZE >> 28) - 1
 	bgt	5f
+	/*
+	 * vmalloc mapping gets the encoding from the PACA as the mapping
+	 * can be demoted from 64K -> 4K dynamically on some machines.
+	 */
 	lhz	r11,PACAVMALLOCSLLP(r13)
 	b	6f
 5:
-- 
2.7.4

  reply	other threads:[~2017-08-01 10:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-01 10:29 [PATCH 1/3] powerpc/mm/book3s64: Make KERN_IO_START a variable Michael Ellerman
2017-08-01 10:29 ` Michael Ellerman [this message]
2017-08-02  8:21   ` [PATCH 2/3] powerpc/mm/slb: Move comment next to the code it's referring to Aneesh Kumar K.V
2017-08-01 10:29 ` [PATCH 3/3] powerpc/mm/hash64: Make vmalloc 56T on hash Michael Ellerman
2017-08-02  8:19   ` Aneesh Kumar K.V
2017-08-03  0:00     ` Michael Ellerman
2017-08-02  8:20 ` [PATCH 1/3] powerpc/mm/book3s64: Make KERN_IO_START a variable Aneesh Kumar K.V
2017-08-02 22:20 ` Balbir Singh
2017-08-08 10:55 ` [1/3] " Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1501583364-14909-2-git-send-email-mpe@ellerman.id.au \
    --to=mpe@ellerman.id.au \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=anton@samba.org \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).