From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: "Michael Ellerman" <mpe@ellerman.id.au>,
"Cédric Le Goater" <clg@kaod.org>,
linuxppc-dev@lists.ozlabs.org
Cc: Paul Mackerras <paulus@samba.org>, Nicholas Piggin <npiggin@gmail.com>
Subject: Re: [PATCH] powerpc/xive: fix the fuzz value in xive_pick_irq_target()
Date: Thu, 03 Aug 2017 10:58:48 +1000 [thread overview]
Message-ID: <1501721928.2664.17.camel@kernel.crashing.org> (raw)
In-Reply-To: <87r2wtr03d.fsf@concordia.ellerman.id.au>
On Thu, 2017-08-03 at 10:01 +1000, Michael Ellerman wrote:
> Benjamin Herrenschmidt <benh@kernel.crashing.org> writes:
>
> > On Wed, 2017-08-02 at 18:43 +0200, Cédric Le Goater wrote:
> > > If xive_find_target_in_mask() fails to find a cpu, the fuzz value used
> > > in xive_pick_irq_target() is decremented and reused in the last
> > > returning call to xive_find_target_in_mask(). This can result in such
> > > WARNINGs if the initial fuzz value is zero :
> >
> > Ah indeed ... would have worked better if "fuzz" had been unsigned.
>
> Is that an ack or a changes requested?
Either ;-) The original code would have been fine with an unsigned, I
didn't realize it was signed and going negative. That said, cedric
patch is fine.
Cheers,
Ben.
next prev parent reply other threads:[~2017-08-03 1:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-02 16:43 [PATCH] powerpc/xive: fix the fuzz value in xive_pick_irq_target() Cédric Le Goater
2017-08-02 21:57 ` Benjamin Herrenschmidt
2017-08-03 0:01 ` Michael Ellerman
2017-08-03 0:58 ` Benjamin Herrenschmidt [this message]
2017-08-03 7:45 ` Cédric Le Goater
2017-08-03 8:02 ` Benjamin Herrenschmidt
2017-08-03 9:52 ` Michael Ellerman
2017-08-03 11:52 ` Benjamin Herrenschmidt
2017-08-03 12:55 ` Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1501721928.2664.17.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=clg@kaod.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).