From: Cyril Bur <cyrilbur@gmail.com>
To: Christophe LEROY <christophe.leroy@c-s.fr>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc: Use reg.h values for program check reason codes
Date: Wed, 16 Aug 2017 19:04:53 +1000 [thread overview]
Message-ID: <1502874293.9868.4.camel@gmail.com> (raw)
In-Reply-To: <52bb17c2-e555-562d-1340-f4e9be11ffe2@c-s.fr>
On Wed, 2017-08-16 at 10:52 +0200, Christophe LEROY wrote:
> Hi,
>
> Le 16/08/2017 à 08:50, Cyril Bur a écrit :
> > Small amount of #define duplication, makes sense for these to be in
> > reg.h.
> >
> > Signed-off-by: Cyril Bur <cyrilbur@gmail.com>
>
> Looks similar to the following applies commit, doesn't it ?
>
> https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?h=merge&id=d30a5a5262ca64d58aa07fb2ecd7f992df83b4bc
>
Oops, I think I'm based off Linus' tree. Sorry for the noise.
Cyril
*starts writing patch to rename to PROGTMBAD*... because clearly haha
;)
> Christophe
>
> > ---
> > arch/powerpc/include/asm/reg.h | 1 +
> > arch/powerpc/kernel/traps.c | 10 +++++-----
> > 2 files changed, 6 insertions(+), 5 deletions(-)
> >
> > diff --git a/arch/powerpc/include/asm/reg.h b/arch/powerpc/include/asm/reg.h
> > index a3b6575c7842..c22b1ae5ad03 100644
> > --- a/arch/powerpc/include/asm/reg.h
> > +++ b/arch/powerpc/include/asm/reg.h
> > @@ -675,6 +675,7 @@
> > * may not be recoverable */
> > #define SRR1_WS_DEEPER 0x00020000 /* Some resources not maintained */
> > #define SRR1_WS_DEEP 0x00010000 /* All resources maintained */
> > +#define SRR1_PROGTMBAD 0x00200000 /* TM Bad Thing */
> > #define SRR1_PROGFPE 0x00100000 /* Floating Point Enabled */
> > #define SRR1_PROGILL 0x00080000 /* Illegal instruction */
> > #define SRR1_PROGPRIV 0x00040000 /* Privileged instruction */
> > diff --git a/arch/powerpc/kernel/traps.c b/arch/powerpc/kernel/traps.c
> > index 1f7ec178db05..0a5ddaea8bf1 100644
> > --- a/arch/powerpc/kernel/traps.c
> > +++ b/arch/powerpc/kernel/traps.c
> > @@ -416,11 +416,11 @@ static inline int check_io_access(struct pt_regs *regs)
> > exception is in the MSR. */
> > #define get_reason(regs) ((regs)->msr)
> > #define get_mc_reason(regs) ((regs)->msr)
> > -#define REASON_TM 0x200000
> > -#define REASON_FP 0x100000
> > -#define REASON_ILLEGAL 0x80000
> > -#define REASON_PRIVILEGED 0x40000
> > -#define REASON_TRAP 0x20000
> > +#define REASON_TM SRR1_PROGTMBAD
> > +#define REASON_FP SRR1_PROGFPE
> > +#define REASON_ILLEGAL SRR1_PROGILL
> > +#define REASON_PRIVILEGED SRR1_PROGPRIV
> > +#define REASON_TRAP SRR1_PROGTRAP
> >
> > #define single_stepping(regs) ((regs)->msr & MSR_SE)
> > #define clear_single_step(regs) ((regs)->msr &= ~MSR_SE)
> >
prev parent reply other threads:[~2017-08-16 9:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-16 6:50 [PATCH] powerpc: Use reg.h values for program check reason codes Cyril Bur
2017-08-16 8:52 ` Christophe LEROY
2017-08-16 9:04 ` Cyril Bur [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1502874293.9868.4.camel@gmail.com \
--to=cyrilbur@gmail.com \
--cc=christophe.leroy@c-s.fr \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).