From: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
To: benh@kernel.crashing.org, mpe@ellerman.id.au
Cc: anton@samba.org, paulus@samba.org, npiggin@gmail.com,
linuxppc-dev@lists.ozlabs.org,
Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
Subject: [PATCH v10 12/14] powerpc:Add new kconfig IRQ_DEBUG_SUPPORT
Date: Sun, 20 Aug 2017 23:28:29 +0530 [thread overview]
Message-ID: <1503251911-30637-13-git-send-email-maddy@linux.vnet.ibm.com> (raw)
In-Reply-To: <1503251911-30637-1-git-send-email-maddy@linux.vnet.ibm.com>
New Kconfig is added "CONFIG_IRQ_DEBUG_SUPPORT" to add warn_on
to alert the invalid transitions. Also moved the code under
the CONFIG_TRACE_IRQFLAGS in arch_local_irq_restore() to new Kconfig.
Reviewed-by: Nicholas Piggin <npiggin@gmail.com>
Signed-off-by: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
---
arch/powerpc/Kconfig | 4 ++++
arch/powerpc/kernel/irq.c | 6 +++---
2 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
index 36f858c37ca7..0a8b730d0e46 100644
--- a/arch/powerpc/Kconfig
+++ b/arch/powerpc/Kconfig
@@ -93,6 +93,10 @@ config TRACE_IRQFLAGS_SUPPORT
bool
default y
+config IRQ_DEBUG_SUPPORT
+ bool
+ default n
+
config LOCKDEP_SUPPORT
bool
default y
diff --git a/arch/powerpc/kernel/irq.c b/arch/powerpc/kernel/irq.c
index fda01a4a3672..324fb2c6f9d8 100644
--- a/arch/powerpc/kernel/irq.c
+++ b/arch/powerpc/kernel/irq.c
@@ -239,7 +239,7 @@ notrace void arch_local_irq_restore(unsigned long en)
unsigned char irq_happened;
unsigned int replay;
-#ifdef CONFIG_TRACE_IRQFLAGS
+#ifdef CONFIG_IRQ_DEBUG_SUPPORT
WARN_ON(en & soft_disable_mask_return() & ~IRQ_DISABLE_MASK_LINUX);
#endif
@@ -278,7 +278,7 @@ notrace void arch_local_irq_restore(unsigned long en)
*/
if (unlikely(irq_happened != PACA_IRQ_HARD_DIS))
__hard_irq_disable();
-#ifdef CONFIG_TRACE_IRQFLAGS
+#ifdef CONFIG_IRQ_DEBUG_SUPPORT
else {
/*
* We should already be hard disabled here. We had bugs
@@ -289,7 +289,7 @@ notrace void arch_local_irq_restore(unsigned long en)
if (WARN_ON(mfmsr() & MSR_EE))
__hard_irq_disable();
}
-#endif /* CONFIG_TRACE_IRQFLAGS */
+#endif /* CONFIG_IRQ_DEBUG_SUPPORT */
soft_disable_mask_set(IRQ_DISABLE_MASK_LINUX);
--
2.7.4
next prev parent reply other threads:[~2017-08-20 17:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-20 17:58 [PATCH v10 00/14] powerpc: "paca->soft_enabled" based local atomic operation implementation Madhavan Srinivasan
2017-08-20 17:58 ` [PATCH v10 01/14] powerpc: Add #defs for paca->soft_enabled flags Madhavan Srinivasan
2017-08-20 17:58 ` [PATCH v10 02/14] powerpc: move set_soft_enabled() and rename Madhavan Srinivasan
2017-08-20 17:58 ` [PATCH v10 03/14] powerpc: Use soft_enabled_set api to update paca->soft_enabled Madhavan Srinivasan
2017-08-20 17:58 ` [PATCH v10 04/14] powerpc: implement arch_local_* using the soft_enabled_* wrappers Madhavan Srinivasan
2017-08-20 17:58 ` [PATCH v10 05/14] powerpc/irq: Cleanup hard_irq_disable() macro Madhavan Srinivasan
2017-08-20 17:58 ` [PATCH v10 06/14] powerpc/irq: Fix arch_local_irq_disable() in book3s Madhavan Srinivasan
2017-08-20 17:58 ` [PATCH v10 07/14] powerpc: Change from enable flag to disable bitmask Madhavan Srinivasan
2017-08-20 17:58 ` [PATCH v10 08/14] powerpc: Rename soft_enabled to soft_disable_mask Madhavan Srinivasan
2017-08-20 17:58 ` [PATCH v10 09/14] powerpc: Avoid using EXCEPTION_PROLOG_1 macro in MASKABLE_* Madhavan Srinivasan
2017-08-20 17:58 ` [PATCH v10 10/14] powerpc: Add support to take additional parameter in MASKABLE_* macro Madhavan Srinivasan
2017-08-20 17:58 ` [PATCH v10 11/14] powerpc: Add support to mask perf interrupts and replay them Madhavan Srinivasan
2017-08-20 17:58 ` Madhavan Srinivasan [this message]
2017-08-20 17:58 ` [PATCH v10 13/14] powerpc: Add new set of soft_disable_mask_ functions Madhavan Srinivasan
2017-08-20 17:58 ` [PATCH v10 14/14] powerpc: rewrite local_t using soft_irq Madhavan Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1503251911-30637-13-git-send-email-maddy@linux.vnet.ibm.com \
--to=maddy@linux.vnet.ibm.com \
--cc=anton@samba.org \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).