From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Dan Streetman <ddstreet@ieee.org>,
Haren Myneni <haren@linux.vnet.ibm.com>
Cc: Michael Ellerman <mpe@ellerman.id.au>,
Herbert Xu <herbert@gondor.apana.org.au>,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
mikey@neuling.org, suka@us.ibm.com, Ram Pai <linuxram@us.ibm.com>,
npiggin@gmail.com, Haren Myneni <hbabu@us.ibm.com>
Subject: Re: [PATCH V3 6/6] crypto/nx: Add P9 NX support for 842 compression engine
Date: Wed, 30 Aug 2017 07:23:37 +1000 [thread overview]
Message-ID: <1504041817.2358.32.camel@kernel.crashing.org> (raw)
In-Reply-To: <CALZtONBGVQy2iwkb8WpVd-_QG7bLFTvUbnuub6CCXP55YpQiSQ@mail.gmail.com>
On Tue, 2017-08-29 at 09:58 -0400, Dan Streetman wrote:
> > +
> > + ret = -EINVAL;
> > + if (coproc && coproc->vas.rxwin) {
> > + wmem->txwin = nx842_alloc_txwin(coproc);
>
> this is wrong. the workmem is scratch memory that's valid only for
> the duration of a single operation.
>
> do you actually need a txwin per crypto transform? or do you need a
> txwin per coprocessor? or txwin per processor? either per-coproc or
> per-cpu should be created at driver init and held separately
> (globally) instead of a per-transform txwin. I really don't see why
> you would need a txwin per transform, because the coproc should not
> care how many different transforms there are.
We should only need a single window for the whole kernel really, plus
one per user process who wants direct access but that's not relevant
here.
Cheers,
Ben.
next prev parent reply other threads:[~2017-08-29 21:24 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-22 5:01 [PATCH V3 6/6] crypto/nx: Add P9 NX support for 842 compression engine Haren Myneni
2017-07-24 16:46 ` Ram Pai
2017-08-28 23:25 ` Michael Ellerman
2017-08-29 13:32 ` Dan Streetman
2017-08-31 7:44 ` Haren Myneni
2017-08-31 13:40 ` Dan Streetman
2017-08-31 19:03 ` Haren Myneni
2017-09-01 11:34 ` Michael Ellerman
2017-09-02 4:11 ` Haren Myneni
2017-08-29 6:30 ` Sukadev Bhattiprolu
2017-08-29 13:58 ` Dan Streetman
2017-08-29 21:23 ` Benjamin Herrenschmidt [this message]
2017-08-29 21:54 ` Haren Myneni
2017-08-29 21:57 ` Benjamin Herrenschmidt
2017-08-30 1:02 ` Haren Myneni
2017-08-31 13:31 ` Dan Streetman
2017-08-31 19:09 ` Haren Myneni
2017-09-01 11:29 ` Michael Ellerman
2017-09-02 3:27 ` Haren Myneni
2017-09-02 16:14 ` Dan Streetman
2017-09-02 8:40 ` Haren Myneni
2017-09-02 13:42 ` Michael Neuling
2017-09-02 16:17 ` Dan Streetman
2017-09-03 8:32 ` Haren Myneni
2017-09-03 14:12 ` Dan Streetman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1504041817.2358.32.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=ddstreet@ieee.org \
--cc=haren@linux.vnet.ibm.com \
--cc=hbabu@us.ibm.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=linuxram@us.ibm.com \
--cc=mikey@neuling.org \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=suka@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).