linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@au1.ibm.com>
To: Balbir Singh <bsingharora@gmail.com>,
	npiggin@gmail.com, mahesh@linux.vnet.ibm.com,
	alistair@popple.id.au
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [rfc 2/3] powerpc/mce: Extract physical_address for UE errors
Date: Thu, 07 Sep 2017 08:56:12 +1000	[thread overview]
Message-ID: <1504738572.2371.3.camel@au1.ibm.com> (raw)
In-Reply-To: <20170905041555.27696-3-bsingharora@gmail.com>

On Tue, 2017-09-05 at 14:15 +1000, Balbir Singh wrote:
>  void save_mce_event(struct pt_regs *regs, long handled,
>                     struct mce_error_info *mce_err,
> -                   uint64_t nip, uint64_t addr)
> +                   uint64_t nip, uint64_t addr, uint64_t phys_addr)
>  {
>         int index = __this_cpu_inc_return(mce_nest_count) - 1;
>         struct machine_check_event *mce = this_cpu_ptr(&mce_event[index]);
> @@ -140,6 +140,10 @@ void save_mce_event(struct pt_regs *regs, long handled,
>         } else if (mce->error_type == MCE_ERROR_TYPE_UE) {
>                 mce->u.ue_error.effective_address_provided = true;
>                 mce->u.ue_error.effective_address = addr;
> +               if (phys_addr != ULONG_MAX) {
> +                       mce->u.ue_error.physical_address_provided = true;
> +                       mce->u.ue_error.physical_address = phys_addr;
> +               }
>         }
>         return;

Where is "addr" coming from ? Keep in mind that on P9 at least, a UE
will *not* give you an EA in DAR in most cases.

Ben.

  parent reply	other threads:[~2017-09-06 22:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-05  4:15 [rfc 0/3] Revisit MCE handling for UE errors Balbir Singh
2017-09-05  4:15 ` [rfc 1/3] powerpc/mce.c: Remove unused function get_mce_fault_addr() Balbir Singh
2017-09-05  4:15 ` [rfc 2/3] powerpc/mce: Extract physical_address for UE errors Balbir Singh
2017-09-06  0:36   ` Nicholas Piggin
2017-09-06  4:37     ` Balbir Singh
2017-09-06 22:56   ` Benjamin Herrenschmidt [this message]
2017-09-07  1:52     ` Balbir Singh
2017-09-08  3:41   ` Mahesh Jagannath Salgaonkar
2017-09-05  4:15 ` [rfc 3/3] powerpc/mce: hookup memory_failure " Balbir Singh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1504738572.2371.3.camel@au1.ibm.com \
    --to=benh@au1.ibm.com \
    --cc=alistair@popple.id.au \
    --cc=bsingharora@gmail.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=mahesh@linux.vnet.ibm.com \
    --cc=npiggin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).