linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: "Cédric Le Goater" <clg@kaod.org>, linuxppc-dev@lists.ozlabs.org
Cc: Michael Ellerman <mpe@ellerman.id.au>,
	David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH 0/2] powerpc/xive: fix CPU hot unplug
Date: Mon, 02 Oct 2017 18:52:37 +0200	[thread overview]
Message-ID: <1506963157.25065.48.camel@kernel.crashing.org> (raw)
In-Reply-To: <378a1945-6263-dca7-3912-b4a2c61794b8@kaod.org>

On Mon, 2017-10-02 at 18:27 +0200, Cédric Le Goater wrote:
> On 09/23/2017 10:26 AM, Cédric Le Goater wrote:
> > Hi,
> > 
> > Here are a couple of small fixes to support CPU hot unplug. There are
> > still some issues to be investigated as, in some occasions, after a
> > couple of plug and unplug, the cpu which was removed receives a 'lost'
> > interrupt. This showed to be the decrementer under QEMU.
> 
> So this seems to be a QEMU issue only which can be solved by 
> removing the DEE bit from the LPCR on P9 processor when the CPU 
> is stopped in rtas. PECE3 bit on P8 processors. 

It should be the same bit no ?

> I think these patches are valuable fixes for 4.14. The first 
> is trivial and the second touches the common xive part but it
> is only called on the pseries platform.  
> 
> Could you please take a look ? 
> 
> Thanks,
> 
> C. 
> 
> > Nevertheless, these patches are required and provide a significant
> > improvement to support CPU removal.
> > 
> > Tested under a phyp and a XIVE QEMU model for pseries.
> > 
> > Thanks,
> > 
> > C.
> > 
> > Cédric Le Goater (2):
> >   powerpc/xive: fix IPI reset
> >   powerpc/xive: fix cpu removal
> > 
> >  arch/powerpc/sysdev/xive/common.c | 8 ++++++++
> >  arch/powerpc/sysdev/xive/spapr.c  | 4 ++++
> >  2 files changed, 12 insertions(+)
> > 

  reply	other threads:[~2017-10-02 16:53 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-23  8:26 [PATCH 0/2] powerpc/xive: fix CPU hot unplug Cédric Le Goater
2017-09-23  8:26 ` [PATCH 1/2] powerpc/xive: fix IPI reset Cédric Le Goater
2017-09-23  8:26 ` [PATCH 2/2] powerpc/xive: fix cpu removal Cédric Le Goater
2017-10-02 16:27 ` [PATCH 0/2] powerpc/xive: fix CPU hot unplug Cédric Le Goater
2017-10-02 16:52   ` Benjamin Herrenschmidt [this message]
2017-10-02 17:53     ` Cédric Le Goater
2017-10-03  3:36   ` David Gibson
2017-10-03  6:24     ` Cédric Le Goater
2017-10-03  6:58       ` David Gibson
2017-10-03  8:22         ` Benjamin Herrenschmidt
2017-10-04 14:48         ` Cédric Le Goater
2017-10-05  3:29         ` Nikunj A Dadhania
2017-10-05  8:18           ` Cédric Le Goater
2017-10-03 11:23   ` Michael Ellerman
2017-10-03 12:58     ` Cédric Le Goater

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1506963157.25065.48.camel@kernel.crashing.org \
    --to=benh@kernel.crashing.org \
    --cc=clg@kaod.org \
    --cc=david@gibson.dropbear.id.au \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).