linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Abdul Haleem <abdhalee@linux.vnet.ibm.com>
To: Zi Yan <zi.yan@cs.rutgers.edu>
Cc: linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
	Anshuman Khandual <khandual@linux.vnet.ibm.com>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	linux-next <linux-next@vger.kernel.org>
Subject: Re: [linux-next] [bisected a4615d11] Memory DLPAR triggers WARN_ONCE() in mm/page_vma_mapped.c
Date: Tue, 03 Oct 2017 14:38:30 +0530	[thread overview]
Message-ID: <1507021710.3792.3.camel@abdul.in.ibm.com> (raw)
In-Reply-To: <08A52087-D1D6-45C9-A660-154EB6BF780B@cs.rutgers.edu>

On Fri, 2017-09-29 at 10:07 -0400, Zi Yan wrote:
> Hi Abdul,
> 
> I just want to follow up with this.
> 
> Did you have a chance to test my patch? Does it fix your original problem?

Yes I did test the patch. it fixes the warning.

Reported-and-tested-by:  Abdul Haleem <abdhalee@linux.vnet.ibm.com>

Thanks for the fix.

--
Regard's

Abdul Haleem
IBM Linux Technology Centre

> 
> On 13 Sep 2017, at 1:48, abdul wrote:
> 
> > On Mon, 2017-09-11 at 10:53 -0400, Zi Yan wrote:
> >> Hi Abdul,
> >>
> >> Can you try this patch below? I think I missed that pmd entries
> >> can be zapped, so the WARN_ONCE is unnecessary.
> >>
> >> Thanks.
> >>
> >> diff --git a/mm/page_vma_mapped.c b/mm/page_vma_mapped.c
> >> index 6a03946469a9..eb462e7db0a9 100644
> >> --- a/mm/page_vma_mapped.c
> >> +++ b/mm/page_vma_mapped.c
> >> @@ -167,8 +167,7 @@ bool page_vma_mapped_walk(struct page_vma_mapped_walk *pvmw)
> >>                                                 return not_found(pvmw);
> >>                                         return true;
> >>                                 }
> >> -                       } else
> >> -                               WARN_ONCE(1, "Non present huge pmd without pmd migration enabled!");
> >> +                       }
> >>                         return not_found(pvmw);
> >>                 } else {
> >>                         /* THP pmd was split under us: handle on pte level */
> >>
> >> --
> >> Best Regards
> >> Yan Zi

      reply	other threads:[~2017-10-03  9:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-11  9:56 [linux-next][bisected a4615d11] Memory DLPAR triggers WARN_ONCE() in mm/page_vma_mapped.c abdul
2017-09-11 14:53 ` [linux-next] [bisected " Zi Yan
2017-09-13  5:48   ` abdul
2017-09-29 14:07     ` Zi Yan
2017-10-03  9:08       ` Abdul Haleem [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1507021710.3792.3.camel@abdul.in.ibm.com \
    --to=abdhalee@linux.vnet.ibm.com \
    --cc=khandual@linux.vnet.ibm.com \
    --cc=linux-next@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=sfr@canb.auug.org.au \
    --cc=zi.yan@cs.rutgers.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).