From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3yNK3M3JmTzDqMY for ; Fri, 27 Oct 2017 07:53:18 +1100 (AEDT) Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id v9QKqa9A073698 for ; Thu, 26 Oct 2017 16:53:16 -0400 Received: from e06smtp13.uk.ibm.com (e06smtp13.uk.ibm.com [195.75.94.109]) by mx0a-001b2d01.pphosted.com with ESMTP id 2dukya953v-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Thu, 26 Oct 2017 16:53:15 -0400 Received: from localhost by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 26 Oct 2017 21:53:13 +0100 Subject: Re: [PATCH v5 00/18] Appended signatures support for IMA appraisal From: Mimi Zohar To: Thiago Jung Bauermann , linux-integrity@vger.kernel.org Cc: linux-security-module@vger.kernel.org, keyrings@vger.kernel.org, linux-crypto@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Dmitry Kasatkin , James Morris , "Serge E. Hallyn" , David Howells , David Woodhouse , Jessica Yu , Rusty Russell , Herbert Xu , "David S. Miller" , "AKASHI, Takahiro" Date: Thu, 26 Oct 2017 16:53:04 -0400 In-Reply-To: <20171018005331.2688-1-bauerman@linux.vnet.ibm.com> References: <20171018005331.2688-1-bauerman@linux.vnet.ibm.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Message-Id: <1509051184.5886.139.camel@linux.vnet.ibm.com> List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, 2017-10-17 at 22:53 -0200, Thiago Jung Bauermann wrote: > Hello, > > The main highlight in this version is that it fixes a bug where the modsig > wasn't being included in the measurement list if the appraised file was > already measured by another rule. The fix is in the last patch. > > Another change is that the last patch in the v4 series ("ima: Support > module-style appended signatures for appraisal") has been broken up into > smaller patches. I may have overdone it... > > Finally, I have added some patches removing superfluous parentheses from > expressions. IMO these patches make it easier (and more pleasant) to read > the code, and thus easier to understand it. Since I'm not sure how welcome > the changes are, I split them in 3 "levels" in increasing potential for > conflict with patches from other people (they can be squashed together when > applied): > > 1. patch 2 contains the bare minimum, changing only lines that are also > touched by other patches in the series; > > 2. patch 3 cleans up all the files that are touched by this patch series; > > 3. patch 4 cleans up all other EVM and IMA files that weren't already fixed > by the previous patches. > > If unwanted, patches 3 and 4 can be simply skipped without affecting the > rest of the patches. I have already rebased them from v4.13-rc2 to > v4.14-rc3 and now to linux-integrity/next with very few easy to resolve > conflicts, so I think they are worth keeping. > > These patches apply on top of today's linux-integrity/next. This cover letter and the patch descriptions are well written, explaining what and why you're making this change.  The problem is that I don't agree that fewer parentheses makes the code more readable.  When you repost the patches (for other reasons), please don't include these changes. thanks, Mimi