From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: "Bryant G. Ly" <bryantly@linux.vnet.ibm.com>,
Daniel Axtens <dja@axtens.net>,
paulus@samba.org, mpe@ellerman.id.au,
tlfalcon@linux.vnet.ibm.com
Cc: linuxppc-dev@lists.ozlabs.org, netdev@vger.kernel.org,
Sivakumar Krishnasamy <ksiva@linux.vnet.ibm.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] ibmveth: Kernel crash LSO offload flag toggle
Date: Thu, 16 Nov 2017 08:57:28 +1100 [thread overview]
Message-ID: <1510783048.2397.68.camel@kernel.crashing.org> (raw)
In-Reply-To: <94eb928a-5d8d-6bf8-9efd-5a9cd602050f@linux.vnet.ibm.com>
On Wed, 2017-11-15 at 10:45 -0600, Bryant G. Ly wrote:
> This patch just closes the window, bad things can still happen. I wanted to leave it
> up to the people who actively develop in ibmveth to close the window, since introducing
> a lock can be expensive in tx.
You don't need to instroduce a lock. The network stack already have a
per-queue lock, you just use the existing one.
Look at what I did in sungem or ftgmac100 with the reset task, those
are fairly simple drivers and should illustrate the technique.
Cheers,
Ben.
next prev parent reply other threads:[~2017-11-16 0:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-14 15:34 [PATCH] ibmveth: Kernel crash LSO offload flag toggle Bryant G. Ly
2017-11-15 2:47 ` Daniel Axtens
2017-11-15 3:14 ` Benjamin Herrenschmidt
2017-11-15 16:45 ` Bryant G. Ly
2017-11-15 21:57 ` Benjamin Herrenschmidt [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-11-13 23:01 Bryant G. Ly
2017-11-14 1:07 ` Daniel Axtens
2017-11-14 15:24 ` Bryant G. Ly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1510783048.2397.68.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=bryantly@linux.vnet.ibm.com \
--cc=dja@axtens.net \
--cc=ksiva@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=netdev@vger.kernel.org \
--cc=paulus@samba.org \
--cc=stable@vger.kernel.org \
--cc=tlfalcon@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).