From: Nicolin Chen <nicoleotsuka@gmail.com>
To: timur@tabi.org, broonie@kernel.org
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
alsa-devel@alsa-project.org, lgirdwood@gmail.com,
fabio.estevam@nxp.com, mail@maciej.szmigiero.name,
caleb@crome.org, arnaud.mouiche@invoxia.com, lukma@denx.de,
kernel@pengutronix.de
Subject: [PATCH v4 08/11] ASoC: fsl_ssi: Rename scr_val to scr
Date: Sun, 17 Dec 2017 18:52:07 -0800 [thread overview]
Message-ID: <1513565530-33957-9-git-send-email-nicoleotsuka@gmail.com> (raw)
In-Reply-To: <1513565530-33957-1-git-send-email-nicoleotsuka@gmail.com>
Simplify the variable name. This reduces one over-80-character line.
Signed-off-by: Nicolin Chen <nicoleotsuka@gmail.com>
Tested-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
Reviewed-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
---
sound/soc/fsl/fsl_ssi.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c
index 237302f..af3ba71 100644
--- a/sound/soc/fsl/fsl_ssi.c
+++ b/sound/soc/fsl/fsl_ssi.c
@@ -451,12 +451,12 @@ static void fsl_ssi_config(struct fsl_ssi *ssi, bool enable,
struct regmap *regs = ssi->regs;
struct fsl_ssi_reg_val *avals;
int nr_active_streams;
- u32 scr_val;
+ u32 scr;
int keep_active;
- regmap_read(regs, REG_SSI_SCR, &scr_val);
+ regmap_read(regs, REG_SSI_SCR, &scr);
- nr_active_streams = !!(scr_val & SSI_SCR_TE) + !!(scr_val & SSI_SCR_RE);
+ nr_active_streams = !!(scr & SSI_SCR_TE) + !!(scr & SSI_SCR_RE);
if (nr_active_streams - 1 > 0)
keep_active = 1;
@@ -810,11 +810,11 @@ static int fsl_ssi_hw_params(struct snd_pcm_substream *substream,
unsigned int sample_size = params_width(hw_params);
u32 wl = SSI_SxCCR_WL(sample_size);
int ret;
- u32 scr_val;
+ u32 scr;
int enabled;
- regmap_read(regs, REG_SSI_SCR, &scr_val);
- enabled = scr_val & SSI_SCR_SSIEN;
+ regmap_read(regs, REG_SSI_SCR, &scr);
+ enabled = scr & SSI_SCR_SSIEN;
/*
* SSI is properly configured if it is enabled and running in
--
2.7.4
next prev parent reply other threads:[~2017-12-18 2:53 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-18 2:51 [PATCH v4 00/11] ASoC: fsl_ssi: Clean up - coding style level Nicolin Chen
2017-12-18 2:52 ` [PATCH v4 01/11] ASoC: fsl_ssi: Rename fsl_ssi_private to fsl_ssi Nicolin Chen
2017-12-18 2:52 ` [PATCH v4 02/11] ASoC: fsl_ssi: Cache pdev->dev pointer Nicolin Chen
2017-12-18 2:52 ` [PATCH v4 03/11] ASoC: fsl_ssi: Refine all comments Nicolin Chen
2017-12-19 11:00 ` Applied "ASoC: fsl_ssi: Refine all comments" to the asoc tree Mark Brown
2017-12-18 2:52 ` [PATCH v4 04/11] ASoC: fsl_ssi: Rename registers and fields macros Nicolin Chen
2017-12-19 11:00 ` Applied "ASoC: fsl_ssi: Rename registers and fields macros" to the asoc tree Mark Brown
2017-12-18 2:52 ` [PATCH v4 05/11] ASoC: fsl_ssi: Refine indentations and wrappings Nicolin Chen
2017-12-19 11:00 ` Applied "ASoC: fsl_ssi: Refine indentations and wrappings" to the asoc tree Mark Brown
2017-12-18 2:52 ` [PATCH v4 06/11] ASoC: fsl_ssi: Refine printk outputs Nicolin Chen
2017-12-18 2:52 ` [PATCH v4 07/11] ASoC: fsl_ssi: Rename cpu_dai parameter to dai Nicolin Chen
2017-12-18 2:52 ` Nicolin Chen [this message]
2017-12-18 2:52 ` [PATCH v4 09/11] ASoC: fsl_ssi: Replace fsl_ssi_rxtx_reg_val with fsl_ssi_regvals Nicolin Chen
2017-12-19 10:59 ` Applied "ASoC: fsl_ssi: Replace fsl_ssi_rxtx_reg_val with fsl_ssi_regvals" to the asoc tree Mark Brown
2017-12-18 2:52 ` [PATCH v4 10/11] ASoC: fsl_ssi: Rename i2smode to i2s_net Nicolin Chen
2017-12-18 2:52 ` [PATCH v4 11/11] ASoC: fsl_ssi: Define ternary macros to simplify code Nicolin Chen
2017-12-18 3:13 ` [PATCH v4 00/11] ASoC: fsl_ssi: Clean up - coding style level Timur Tabi
2017-12-18 22:19 ` Caleb Crome
2017-12-18 23:02 ` Nicolin Chen
2017-12-19 0:25 ` Caleb Crome
2017-12-20 11:40 ` Arnaud Mouiche
2017-12-20 17:26 ` Nicolin Chen
2017-12-21 16:08 ` Caleb Crome
2017-12-21 16:10 ` Caleb Crome
2017-12-21 16:21 ` Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1513565530-33957-9-git-send-email-nicoleotsuka@gmail.com \
--to=nicoleotsuka@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnaud.mouiche@invoxia.com \
--cc=broonie@kernel.org \
--cc=caleb@crome.org \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lukma@denx.de \
--cc=mail@maciej.szmigiero.name \
--cc=timur@tabi.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).