* Re: [PATCH] powerpc/eeh: Add conditional check on notify_resume
2018-02-15 18:49 [PATCH] powerpc/eeh: Add conditional check on notify_resume Bryant G. Ly
@ 2018-02-15 23:21 ` Andrew Donnellan
2018-02-16 13:25 ` Mauro Rodrigues
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Andrew Donnellan @ 2018-02-15 23:21 UTC (permalink / raw)
To: Bryant G. Ly, benh, paulus, mpe; +Cc: aik, linuxppc-dev, jjalvare, seroyer
On 16/02/18 05:49, Bryant G. Ly wrote:
> From: "Juan J. Alvarez" <jjalvare@linux.vnet.ibm.com>
>
> EEH structure is not populated with function
> notify resume when running on systems that do not support
> it, i.e: BMC. Hence adding a conditional check for NULL for
Seems to me that by "BMC" you really mean "powernv platform"?
> systems that don't add function notify_resume.
>
> Signed-off-by: Juan J. Alvarez <jjalvare@linux.vnet.ibm.com>
> Reviewed-by: Bryant G. Ly <bryantly@linux.vnet.ibm.com>
> Tested-by: Carol L. Soto <clsoto@us.ibm.com>
Reviewed-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
> ---
> arch/powerpc/kernel/eeh_driver.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/kernel/eeh_driver.c b/arch/powerpc/kernel/eeh_driver.c
> index beea218..0c0b66f 100644
> --- a/arch/powerpc/kernel/eeh_driver.c
> +++ b/arch/powerpc/kernel/eeh_driver.c
> @@ -384,7 +384,8 @@ static void *eeh_report_resume(void *data, void *userdata)
> eeh_pcid_put(dev);
> pci_uevent_ers(dev, PCI_ERS_RESULT_RECOVERED);
> #ifdef CONFIG_PCI_IOV
> - eeh_ops->notify_resume(eeh_dev_to_pdn(edev));
> + if (eeh_ops->notify_resume && eeh_dev_to_pdn(edev))
> + eeh_ops->notify_resume(eeh_dev_to_pdn(edev));
> #endif
> return NULL;
> }
>
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnellan@au1.ibm.com IBM Australia Limited
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] powerpc/eeh: Add conditional check on notify_resume
2018-02-15 18:49 [PATCH] powerpc/eeh: Add conditional check on notify_resume Bryant G. Ly
2018-02-15 23:21 ` Andrew Donnellan
@ 2018-02-16 13:25 ` Mauro Rodrigues
2018-02-20 10:42 ` Michael Neuling
2018-02-21 13:43 ` Michael Ellerman
3 siblings, 0 replies; 5+ messages in thread
From: Mauro Rodrigues @ 2018-02-16 13:25 UTC (permalink / raw)
To: Bryant G. Ly; +Cc: benh, paulus, mpe, aik, linuxppc-dev, jjalvare, seroyer
On Thu, Feb 15, 2018 at 12:49:51PM -0600, Bryant G. Ly wrote:
> From: "Juan J. Alvarez" <jjalvare@linux.vnet.ibm.com>
>
> EEH structure is not populated with function
> notify resume when running on systems that do not support
> it, i.e: BMC. Hence adding a conditional check for NULL for
> systems that don't add function notify_resume.
>
> Signed-off-by: Juan J. Alvarez <jjalvare@linux.vnet.ibm.com>
> Reviewed-by: Bryant G. Ly <bryantly@linux.vnet.ibm.com>
> Tested-by: Carol L. Soto <clsoto@us.ibm.com>
Tested-by: Mauro S. M. Rodrigues <maurosr@linux.vnet.ibm.com>
Thanks! I was debugging it and I'm glad you proposed a fix already.
> ---
> arch/powerpc/kernel/eeh_driver.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/kernel/eeh_driver.c b/arch/powerpc/kernel/eeh_driver.c
> index beea218..0c0b66f 100644
> --- a/arch/powerpc/kernel/eeh_driver.c
> +++ b/arch/powerpc/kernel/eeh_driver.c
> @@ -384,7 +384,8 @@ static void *eeh_report_resume(void *data, void *userdata)
> eeh_pcid_put(dev);
> pci_uevent_ers(dev, PCI_ERS_RESULT_RECOVERED);
> #ifdef CONFIG_PCI_IOV
> - eeh_ops->notify_resume(eeh_dev_to_pdn(edev));
> + if (eeh_ops->notify_resume && eeh_dev_to_pdn(edev))
> + eeh_ops->notify_resume(eeh_dev_to_pdn(edev));
> #endif
> return NULL;
> }
> --
> 2.7.2
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] powerpc/eeh: Add conditional check on notify_resume
2018-02-15 18:49 [PATCH] powerpc/eeh: Add conditional check on notify_resume Bryant G. Ly
2018-02-15 23:21 ` Andrew Donnellan
2018-02-16 13:25 ` Mauro Rodrigues
@ 2018-02-20 10:42 ` Michael Neuling
2018-02-21 13:43 ` Michael Ellerman
3 siblings, 0 replies; 5+ messages in thread
From: Michael Neuling @ 2018-02-20 10:42 UTC (permalink / raw)
To: Bryant G. Ly, benh, paulus, mpe; +Cc: aik, linuxppc-dev, jjalvare, seroyer
On Thu, 2018-02-15 at 12:49 -0600, Bryant G. Ly wrote:
> From: "Juan J. Alvarez" <jjalvare@linux.vnet.ibm.com>
>=20
> EEH structure is not populated with function
> notify resume when running on systems that do not support
> it, i.e: BMC. Hence adding a conditional check for NULL for
> systems that don't add function notify_resume.
>=20
> Signed-off-by: Juan J. Alvarez <jjalvare@linux.vnet.ibm.com>
> Reviewed-by: Bryant G. Ly <bryantly@linux.vnet.ibm.com>
> Tested-by: Carol L. Soto <clsoto@us.ibm.com>
Acked-by: Michael Neuling <mikey@neuling.org>
> ---
> arch/powerpc/kernel/eeh_driver.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>=20
> diff --git a/arch/powerpc/kernel/eeh_driver.c
> b/arch/powerpc/kernel/eeh_driver.c
> index beea218..0c0b66f 100644
> --- a/arch/powerpc/kernel/eeh_driver.c
> +++ b/arch/powerpc/kernel/eeh_driver.c
> @@ -384,7 +384,8 @@ static void *eeh_report_resume(void *data, void *user=
data)
> eeh_pcid_put(dev);
> pci_uevent_ers(dev, PCI_ERS_RESULT_RECOVERED);
> #ifdef CONFIG_PCI_IOV
> - eeh_ops->notify_resume(eeh_dev_to_pdn(edev));
> + if (eeh_ops->notify_resume && eeh_dev_to_pdn(edev))
> + eeh_ops->notify_resume(eeh_dev_to_pdn(edev));
> #endif
> return NULL;
> }
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: powerpc/eeh: Add conditional check on notify_resume
2018-02-15 18:49 [PATCH] powerpc/eeh: Add conditional check on notify_resume Bryant G. Ly
` (2 preceding siblings ...)
2018-02-20 10:42 ` Michael Neuling
@ 2018-02-21 13:43 ` Michael Ellerman
3 siblings, 0 replies; 5+ messages in thread
From: Michael Ellerman @ 2018-02-21 13:43 UTC (permalink / raw)
To: Bryant G. Ly, benh, paulus; +Cc: aik, linuxppc-dev, jjalvare, seroyer
On Thu, 2018-02-15 at 18:49:51 UTC, "Bryant G. Ly" wrote:
> From: "Juan J. Alvarez" <jjalvare@linux.vnet.ibm.com>
>
> EEH structure is not populated with function
> notify resume when running on systems that do not support
> it, i.e: BMC. Hence adding a conditional check for NULL for
> systems that don't add function notify_resume.
>
> Signed-off-by: Juan J. Alvarez <jjalvare@linux.vnet.ibm.com>
> Reviewed-by: Bryant G. Ly <bryantly@linux.vnet.ibm.com>
> Tested-by: Carol L. Soto <clsoto@us.ibm.com>
> Reviewed-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
> Tested-by: Mauro S. M. Rodrigues <maurosr@linux.vnet.ibm.com>
> Acked-by: Michael Neuling <mikey@neuling.org>
Applied to powerpc fixes, thanks.
https://git.kernel.org/powerpc/c/521ca5a9859a870e354d1a6b84a6ff
cheers
^ permalink raw reply [flat|nested] 5+ messages in thread