From: "Alastair D'Silva" <alastair@au1.ibm.com>
To: Frederic Barrat <fbarrat@linux.vnet.ibm.com>,
Balbir Singh <bsingharora@gmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
frederic.barrat@fr.ibm.com, Greg KH <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linuxppc-dev <linuxppc-dev@ozlabs.org>,
Andrew Donnellan <andrew.donnellan@au1.ibm.com>
Subject: Re: [PATCH] ocxl: Add get_metadata IOCTL to share OCXL information to userspace
Date: Thu, 22 Feb 2018 10:37:43 +1100 [thread overview]
Message-ID: <1519256263.2867.8.camel@au1.ibm.com> (raw)
In-Reply-To: <c6017f9f-67f0-10eb-1eed-527c9c5298ba@linux.vnet.ibm.com>
On Wed, 2018-02-21 at 12:25 +0100, Frederic Barrat wrote:
>
> Le 21/02/2018 à 07:43, Balbir Singh a écrit :
> > On Wed, Feb 21, 2018 at 3:57 PM, Alastair D'Silva <alastair@au1.ibm
> > .com> wrote:
> > > From: Alastair D'Silva <alastair@d-silva.org>
> > >
> > > Some required information is not exposed to userspace currently
> > > (eg. the
> > > PASID), pass this information back, along with other information
> > > which
> > > is currently communicated via sysfs, which saves some parsing
> > > effort in
> > > userspace.
> > >
> > > Signed-off-by: Alastair D'Silva <alastair@d-silva.org>
> > >
<snip>
> > Should we document the fields? pp_ stands for per process, but is
> > not
> > very clear at first look. Why do we care to return only the size,
> > what
> > about lpc size?
>
> My bad, I forgot to mention it before. There's a somewhat high-level
> description which needs updating in:
> Documentation/accelerators/ocxl.rst
>
> It doesn't go down to the level of the structure members, but at
> least
> all ioctl commands should have a brief description.
>
I'll update the docs.
> lpc_size could be added. It's currently useless to the library, but
> doesn't hurt. The one which was giving me troubles on a previous
> version
> of this patch was the lpc numa node ID, since that was experimental
> code
> and felt out of place considering what's been upstreamed in skiboot
> and
> linux so far.
I'd rather add the LPC members when the rest of the LPC code goes in.
At the moment, the LPC size represents the window size (as a power of
2), whereas we expect that it should represent the actual amount of LPC
memory exposed. I would rather avoid changing semantics of members in
released code, or burning another reserved member for the updated
definition if we can avoid it.
--
Alastair D'Silva
Open Source Developer
Linux Technology Centre, IBM Australia
mob: 0423 762 819
next prev parent reply other threads:[~2018-02-21 23:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-21 4:57 [PATCH] ocxl: Add get_metadata IOCTL to share OCXL information to userspace Alastair D'Silva
2018-02-21 5:49 ` Andrew Donnellan
2018-02-21 6:43 ` Balbir Singh
2018-02-21 11:25 ` Frederic Barrat
2018-02-21 23:37 ` Alastair D'Silva [this message]
2018-02-22 3:46 ` Balbir Singh
2018-02-22 3:51 ` Alastair D'Silva
2018-02-22 5:32 ` Balbir Singh
2018-02-22 12:04 ` Frederic Barrat
2018-02-21 23:32 ` Alastair D'Silva
2018-02-22 3:19 ` Michael Ellerman
2018-02-22 3:41 ` Balbir Singh
2018-02-22 3:47 ` Andrew Donnellan
2018-02-22 3:48 ` Alastair D'Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1519256263.2867.8.camel@au1.ibm.com \
--to=alastair@au1.ibm.com \
--cc=andrew.donnellan@au1.ibm.com \
--cc=arnd@arndb.de \
--cc=bsingharora@gmail.com \
--cc=fbarrat@linux.vnet.ibm.com \
--cc=frederic.barrat@fr.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).