From: Russell Currey <ruscur@russell.cc>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Michael Neuling <mikey@neuling.org>,
mpe@ellerman.id.au
Cc: linuxppc-dev@lists.ozlabs.org, sam.bobroff@au1.ibm.com
Subject: Re: [PATCH] powerpc/eeh: Fix race with driver un/bind
Date: Mon, 26 Mar 2018 10:30:03 +1100 [thread overview]
Message-ID: <1522020603.2398.0.camel@russell.cc> (raw)
In-Reply-To: <1521786791.16434.339.camel@kernel.crashing.org>
On Fri, 2018-03-23 at 17:33 +1100, Benjamin Herrenschmidt wrote:
> On Fri, 2018-03-23 at 16:44 +1100, Michael Neuling wrote:
>
> .../...
>
> > This fixes the problem in the same way the generic PCIe AER code
> > (in
> > drivers/pci/pcie/aer/aerdrv_core.c) does. It makes the EEH code
> > hold
> > the device_lock() before performing the driver EEH callbacks. This
> > ensures either the callbacks are no longer register, or if they are
> > registered the driver will not be removed from underneath us.
> >
> > Signed-off-by: Michael Neuling <mikey@neuling.org>
>
> Generally ok, minor nits though and do we want a CC stable ?
I definitely think this should go to stable.
next prev parent reply other threads:[~2018-03-25 23:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-23 5:44 [PATCH] powerpc/eeh: Fix race with driver un/bind Michael Neuling
2018-03-23 6:33 ` Benjamin Herrenschmidt
2018-03-25 23:30 ` Russell Currey [this message]
2018-03-26 2:47 ` Michael Neuling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1522020603.2398.0.camel@russell.cc \
--to=ruscur@russell.cc \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mikey@neuling.org \
--cc=mpe@ellerman.id.au \
--cc=sam.bobroff@au1.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).