From: Russell Currey <ruscur@russell.cc>
To: "Mauro S. M. Rodrigues" <maurosr@linux.vnet.ibm.com>,
linuxppc-dev@lists.ozlabs.org, benh@kernel.crashing.org,
paulus@samba.org, mpe@ellerman.id.au
Cc: kernel@gpiccoli.net
Subject: Re: [PATCH] powerpc/eeh: Avoid misleading message "EEH: no capable adapters found"
Date: Fri, 27 Apr 2018 10:34:48 +1000 [thread overview]
Message-ID: <1524789288.2096.0.camel@russell.cc> (raw)
In-Reply-To: <1521771052-5973-1-git-send-email-maurosr@linux.vnet.ibm.com>
On Thu, 2018-03-22 at 23:10 -0300, Mauro S. M. Rodrigues wrote:
> Due to recent refactoring in EEH in:
> commit b9fde58db7e5 ("powerpc/powernv: Rework EEH initialization on
> powernv")
> a misleading message was seen in the kernel message buffer:
>
> [ 0.108431] EEH: PowerNV platform initialized
> [ 0.589979] EEH: No capable adapters found
>
> This happened due to the removal of the initialization delay for
> powernv
> platform.
>
> Even though the EEH infrastructure for the devices is eventually
> initialized and still works just fine the eeh device probe step is
> postponed in order to assure the PEs are created. Later
> pnv_eeh_post_init does the probe devices job but at that point the
> message was already shown right after eeh_init flow.
>
> This patch introduces a new flag EEH_POSTPONED_PROBE to represent
> that
> temporary state and avoid the message mentioned above and showing the
> follow one instead:
>
> [ 0.107724] EEH: PowerNV platform initialized
> [ 4.844825] EEH: PCI Enhanced I/O Error Handling Enabled
>
> Signed-off-by: Mauro S. M. Rodrigues <maurosr@linux.vnet.ibm.com>
Good idea, thanks for the patch.
Acked-by: Russell Currey <ruscur@russell.cc>
next prev parent reply other threads:[~2018-04-27 0:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-23 2:10 [PATCH] powerpc/eeh: Avoid misleading message "EEH: no capable adapters found" Mauro S. M. Rodrigues
2018-04-27 0:34 ` Russell Currey [this message]
2018-06-18 7:17 ` Venkat Rao B
2018-07-11 13:24 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1524789288.2096.0.camel@russell.cc \
--to=ruscur@russell.cc \
--cc=benh@kernel.crashing.org \
--cc=kernel@gpiccoli.net \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maurosr@linux.vnet.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).