linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>
To: Luke Dashjr <luke@dashjr.org>, Ingo Molnar <mingo@redhat.com>,
	Paul Mackerras <paulus@ozlabs.org>,
	Steven Rostedt <rostedt@goodmis.org>
Cc: kvm-ppc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	Michael Ellerman <mpe@ellerman.id.au>
Subject: Re: [PATCH] powerpc64/ftrace: Include ftrace.h needed for enable/disable calls
Date: Fri, 17 Aug 2018 15:55:40 +0530	[thread overview]
Message-ID: <1534501411.hvsbp9w9ur.naveen@linux.ibm.com> (raw)
In-Reply-To: <201808162136.27788.luke@dashjr.org>

Luke Dashjr wrote:
> this_cpu_disable_ftrace and this_cpu_enable_ftrace are inlines in ftrace.=
h
> Without it included, the build fails.

I'm unable to reproduce this. Can you share your .config and the build=20
environment?

>=20
> Fixes: a4bc64d305af ("powerpc64/ftrace: Disable ftrace during kvm entry/e=
xit")
> Signed-off-by: Luke Dashjr <luke-jr+git@utopios.org>
> Cc: stable@vger.kernel.org
> ---
>  arch/powerpc/kvm/book3s_hv.c | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/arch/powerpc/kvm/book3s_hv.c b/arch/powerpc/kvm/book3s_hv.c
> index ee4a8854985e..15c2c64291f4 100644
> --- a/arch/powerpc/kvm/book3s_hv.c
> +++ b/arch/powerpc/kvm/book3s_hv.c
> @@ -46,6 +46,7 @@
>  #include <linux/compiler.h>
>  #include <linux/of.h>
>=20
> +#include <asm/ftrace.h>
>  #include <asm/reg.h>
>  #include <asm/ppc-opcode.h>
>  #include <asm/asm-prototypes.h>

In any case, this change itself looks alright to me. So:
Acked-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>


Thanks,
Naveen

=

       reply	other threads:[~2018-08-17 10:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <201808162136.27788.luke@dashjr.org>
2018-08-17 10:25 ` Naveen N. Rao [this message]
2018-08-17 15:16   ` [PATCH] powerpc64/ftrace: Include ftrace.h needed for enable/disable calls Luke Dashjr
2018-08-17 16:41     ` Naveen N. Rao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1534501411.hvsbp9w9ur.naveen@linux.ibm.com \
    --to=naveen.n.rao@linux.vnet.ibm.com \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=luke@dashjr.org \
    --cc=mingo@redhat.com \
    --cc=mpe@ellerman.id.au \
    --cc=paulus@ozlabs.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).