linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>
To: Luke Dashjr <luke@dashjr.org>
Cc: kvm-ppc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	Ingo Molnar <mingo@redhat.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Paul Mackerras <paulus@ozlabs.org>,
	Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH] powerpc64/ftrace: Include ftrace.h needed for enable/disable calls
Date: Fri, 17 Aug 2018 22:11:10 +0530	[thread overview]
Message-ID: <1534524010.ixq4fqaac8.naveen@linux.ibm.com> (raw)
In-Reply-To: <201808171516.34356.luke@dashjr.org>

Luke Dashjr wrote:
> On Friday 17 August 2018 10:25:40 Naveen N. Rao wrote:
>> Luke Dashjr wrote:
>> > this_cpu_disable_ftrace and this_cpu_enable_ftrace are inlines in
>> > ftrace.h Without it included, the build fails.
>>
>> I'm unable to reproduce this. Can you share your .config and the build
>> environment?
>=20
> https://luke.dashjr.org/tmp/code/4.18-config.xz
>=20
> Gentoo GNU/Linux (mostly stable keywords) on a Raptor Talos II POWER9 sys=
tem.

Thanks. Your config is missing CONFIG_TRACEPOINTS and I hadn't tested=20
that. The below fix looks good and I've confirmed that the other uses=20
are fine as well.

- Naveen

=

      reply	other threads:[~2018-08-17 16:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <201808162136.27788.luke@dashjr.org>
2018-08-17 10:25 ` [PATCH] powerpc64/ftrace: Include ftrace.h needed for enable/disable calls Naveen N. Rao
2018-08-17 15:16   ` Luke Dashjr
2018-08-17 16:41     ` Naveen N. Rao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1534524010.ixq4fqaac8.naveen@linux.ibm.com \
    --to=naveen.n.rao@linux.vnet.ibm.com \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=luke@dashjr.org \
    --cc=mingo@redhat.com \
    --cc=mpe@ellerman.id.au \
    --cc=paulus@ozlabs.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).