linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>
To: Breno Leitao <leitao@debian.org>, Michael Ellerman <mpe@ellerman.id.au>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] selftests/powerpc: Fix compilation issue due to asm label
Date: Wed, 31 Oct 2018 22:54:39 +0530	[thread overview]
Message-ID: <1541006651.phri6idrd6.naveen@linux.ibm.com> (raw)
In-Reply-To: <20181031171813.8970-1-naveen.n.rao@linux.vnet.ibm.com>

Naveen N. Rao wrote:
> We are using 'dscr_insn' as a label in inline asm to identify if a
> SIGILL was generated by the mtspr instruction at that point. However,
> with inline assembly, the compiler is still free to duplicate the asm
> statement for optimization purposes, which results in the label being
> defined twice with the error:
> 	/tmp/ccerQCql.s:874: Error: symbol `dscr_insn' is already defined
> 
> With different compiler versions, we may also see:
> 	/tmp/ccJzLDlN.o:(.toc+0x0): undefined reference to `dscr_insn'
> 
> Remove the use of the label in the inline assembly. Instead, just look
> for the offending instruction in the signal handler.
> 
> Reported-by: Breno Leitao <leitao@debian.org>
> Signed-off-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
> ---

Missed adding:
Fixes: d2bf793237b3aa9c ("selftests/powerpc: Add test to verify rfi flush across a system call")

- Naveen



  reply	other threads:[~2018-10-31 17:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-31 17:18 [PATCH] selftests/powerpc: Fix compilation issue due to asm label Naveen N. Rao
2018-10-31 17:24 ` Naveen N. Rao [this message]
2018-10-31 19:05   ` Breno Leitao
2018-11-01 12:46 ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1541006651.phri6idrd6.naveen@linux.ibm.com \
    --to=naveen.n.rao@linux.vnet.ibm.com \
    --cc=leitao@debian.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).