From: Paul Mackerras <paulus@samba.org>
To: linuxppc-dev@lists.linuxppc.org
Subject: OpenPIC_NumInitSenses
Date: Thu, 24 Jan 2002 23:13:26 +1100 (EST) [thread overview]
Message-ID: <15439.64102.68217.293733@argo.ozlabs.ibm.com> (raw)
Who was it that wanted this horrible hack in open_pic.c?
/* Needed because of the way we overload EPIC on a standard
* Open PIC structure.
*/
if (OpenPIC_NumInitSenses > NumSources)
NumSources = OpenPIC_NumInitSenses;
I am about to add an openpic_set_sources function which will let us
handle the distributed openpic in IBM pSeries machines more cleanly
and also allow us to remove this hack.
openpic_set_sources takes three arguments: a range of openpic IRQ
numbers (first irq and number of irqs) and a pointer to the ioremapped
interrupt source registers. If the pointer is NULL it is taken to
mean that the irqs use the standard openpic interrupt source
registers. openpic_set_sources also sets NumSources to first_irq +
num_irqs if that value is larger than NumSources, and if NumSources is
set by openpic_set_sources, then openpic_init doesn't use the value
from the openpic registers. (Thus openpic_set_sources must be called
*before* openpic_init, but after you have set OpenPIC_Addr.)
Thus if you want to say how many interrupt sources there are, you will
be able to do that with openpic_set_sources(0, num_sources, NULL).
If you want to say that there are 16 sources in the standard locations
plus another 16 at some other location, you could do
openpic_set_sources(0, 16, NULL);
openpic_set_sources(16, 16, ioremap(isr_base, 16 * 32));
(Actually maybe I should let openpic_set_sources do the ioremap.)
Comments?
Paul.
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
next reply other threads:[~2002-01-24 12:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-01-24 12:13 Paul Mackerras [this message]
2002-01-24 17:54 ` OpenPIC_NumInitSenses Adrian Cox
2002-01-25 2:42 ` OpenPIC_NumInitSenses Dan Malek
2002-01-25 4:04 ` OpenPIC_NumInitSenses Paul Mackerras
2002-01-25 17:07 ` OpenPIC_NumInitSenses Dan Malek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15439.64102.68217.293733@argo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=linuxppc-dev@lists.linuxppc.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).