From: David Howells <dhowells@redhat.com>
To: Vitaly Mayatskikh <v.mayatskih@gmail.com>
Cc: linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>
Subject: Re: take in count O_NONBLOCK flag for rtas log
Date: Thu, 25 Sep 2008 22:13:05 +0100 [thread overview]
Message-ID: <1545.1222377185@redhat.com> (raw)
In-Reply-To: <m34p44cbpz.wl%vmayatsk@redhat.com>
Vitaly Mayatskikh <v.mayatskih@gmail.com> wrote:
> + if (!logging_enabled) {
> + spin_unlock_irqrestore(&rtasd_log_lock, s);
> + error = -ENODATA;
> + goto out;
> + } else
> + nvram_clear_error_log();
The 'else' here is unnecessary. It's preceded inside the curlies by a goto.
David
next prev parent reply other threads:[~2008-09-25 21:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-25 18:38 take in count O_NONBLOCK flag for rtas log Vitaly Mayatskikh
2008-09-25 21:13 ` David Howells [this message]
2008-09-26 8:21 ` Vitaly Mayatskikh
2008-09-29 9:24 ` Vitaly Mayatskikh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1545.1222377185@redhat.com \
--to=dhowells@redhat.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=v.mayatskih@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).