linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] powerpc: Fix error when cross building TAGS & cscope
@ 2013-11-21  3:59 Michael Neuling
  0 siblings, 0 replies; only message in thread
From: Michael Neuling @ 2013-11-21  3:59 UTC (permalink / raw)
  To: benh; +Cc: Linux PPC dev, Ian Munsie, anton

Currently if I cross build TAGS or cscope from x86 I get this:
  % make ARCH=3Dpowerpc TAGS
  gcc-4.8.real: error: unrecognized command line option =E2=80=98-mbig-endi=
an=E2=80=99
  GEN     TAGS
  %=20

I'm not setting CROSS_COMPILE=3D as logically I shouldn't need to and I
haven't needed to in the past when building TAGS or cscope.  Also, the
above completess correct as the error is not fatal to the build.

This was caused by:
    commit d72b08017161ab385d4ae080ea415c9eb7ceef83
    Author: Ian Munsie <imunsie@au1.ibm.com>
    powerpc: Add ability to build little endian kernels

The below fixes this by testing for the -mbig-endian option before
adding it.

I've not done the same thing in the little endian case as if
-mlittle-endian doesn't exist, we probably want to fail quickly as you
probably have an old big endian compiler.

Signed-off-by: Michael Neuling <mikey@neuling.org>

diff --git a/arch/powerpc/Makefile b/arch/powerpc/Makefile
index 8a24636..273ace7 100644
--- a/arch/powerpc/Makefile
+++ b/arch/powerpc/Makefile
@@ -75,8 +75,10 @@ LDEMULATION	:=3D lppc
 GNUTARGET	:=3D powerpcle
 MULTIPLEWORD	:=3D -mno-multiple
 else
+ifeq ($(call cc-option-yn,-mbig-endian),y)
 override CC	+=3D -mbig-endian
 override AS	+=3D -mbig-endian
+endif
 override LD	+=3D -EB
 LDEMULATION	:=3D ppc
 GNUTARGET	:=3D powerpc

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2013-11-21  3:59 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-21  3:59 [PATCH] powerpc: Fix error when cross building TAGS & cscope Michael Neuling

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).