From: Viorel Suman <viorel.suman@nxp.com>
To: Daniel Baluta <daniel.baluta@nxp.com>,
"broonie@kernel.org" <broonie@kernel.org>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"timur@kernel.org" <timur@kernel.org>,
"Xiubo.Lee@gmail.com" <Xiubo.Lee@gmail.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"S.j. Wang" <shengjiu.wang@nxp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"tiwai@suse.com" <tiwai@suse.com>,
dl-linux-imx <linux-imx@nxp.com>,
"perex@perex.cz" <perex@perex.cz>,
"festevam@gmail.com" <festevam@gmail.com>
Subject: Re: [PATCH v3 0/3] Add runtime PM for SAI digital audio interface
Date: Tue, 23 Apr 2019 07:20:28 +0000 [thread overview]
Message-ID: <1556004028.2595.2.camel@nxp.com> (raw)
In-Reply-To: <20190422190213.30726-1-daniel.baluta@nxp.com>
For this series:
Reviewed-by: Viorel Suman <viorel.suman@nxp.com>
On Lu, 2019-04-22 at 19:02 +0000, Daniel Baluta wrote:
> First patch fixes a bug by correctly setting is_slave_mode, then
> second patch adds support for runtime PM and finally 3rd patch moves
> clock handling from startup/shtudown function to runtime PM handlers.
>
> Changes since v2: (after Viorel's comments)
> - no need to check for is_slave_mode when enabling/disabling the clocks
> because sai->mclk_streams is only set when SAI is in master mode.
>
> Changes since v1: (after Nicolin's comments)
> - added patch 1
> - added fsl_sai_remove in order to call pm_runtime_disable
> - only disable/enable mclk when SAI in master mode.
>
> Daniel Baluta (2):
> ASoC: fsl_sai: Update is_slave_mode with correct value
> ASoC: fsl_sai: Add support for runtime pm
>
> Shengjiu Wang (1):
> ASoC: fsl_sai: Move clock operation to PM runtime
>
> sound/soc/fsl/fsl_sai.c | 78 +++++++++++++++++++++++++++++++++--------
> 1 file changed, 63 insertions(+), 15 deletions(-)
>
> --
> 2.17.1
>
prev parent reply other threads:[~2019-04-23 7:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-22 19:02 [PATCH v3 0/3] Add runtime PM for SAI digital audio interface Daniel Baluta
2019-04-22 19:02 ` [PATCH v3 1/3] ASoC: fsl_sai: Update is_slave_mode with correct value Daniel Baluta
2019-04-22 19:02 ` [PATCH v3 2/3] ASoC: fsl_sai: Add support for runtime pm Daniel Baluta
2019-04-22 19:02 ` [PATCH v3 3/3] ASoC: fsl_sai: Move clock operation to PM runtime Daniel Baluta
2019-04-26 12:11 ` Daniel Baluta
2019-04-23 7:20 ` Viorel Suman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1556004028.2595.2.camel@nxp.com \
--to=viorel.suman@nxp.com \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=daniel.baluta@nxp.com \
--cc=festevam@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=perex@perex.cz \
--cc=shengjiu.wang@nxp.com \
--cc=timur@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).