public inbox for linuxppc-dev@ozlabs.org
 help / color / mirror / Atom feed
From: Jori Koolstra <jkoolstra@xs4all.nl>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Madhavan Srinivasan <maddy@linux.ibm.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Nicholas Piggin <npiggin@gmail.com>,
	"Christophe Leroy (CS GROUP)" <chleroy@kernel.org>,
	Srikar Dronamraju <srikar@linux.ibm.com>,
	Shrikanth Hegde <sshegde@linux.ibm.com>,
	Kees Cook <kees@kernel.org>, Haren Myneni <haren@linux.ibm.com>,
	"open list:LINUX FOR POWERPC (32-BIT AND 64-BIT)"
	<linuxppc-dev@lists.ozlabs.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] powerpc: vas-api: constify dynamic struct class in coproc api register
Date: Sun, 8 Mar 2026 23:15:40 +0100 (CET)	[thread overview]
Message-ID: <1567347751.876335.1773008140595@kpc.webmail.kpnmail.nl> (raw)
In-Reply-To: <2026030846-wince-recess-c338@gregkh>


> Op 08-03-2026 17:19 CET schreef Greg KH <gregkh@linuxfoundation.org>:
> 
>  
> On Sun, Mar 08, 2026 at 01:39:12PM +0100, Jori Koolstra wrote:
> > diff --git a/arch/powerpc/platforms/powernv/vas-window.c b/arch/powerpc/platforms/powernv/vas-window.c
> > index 9f093176b8db..34403582c895 100644
> > --- a/arch/powerpc/platforms/powernv/vas-window.c
> > +++ b/arch/powerpc/platforms/powernv/vas-window.c
> > @@ -1459,7 +1459,6 @@ static const struct vas_user_win_ops vops =  {
> >  int vas_register_api_powernv(struct module *mod, enum vas_cop_type cop_type,
> >  			     const char *name)
> >  {
> > -
> >  	return vas_register_coproc_api(mod, cop_type, name, &vops);
> >  }
> >  EXPORT_SYMBOL_GPL(vas_register_api_powernv);
> > 
> 
> This change wasn't needed here :(
> 
> thanks,
> 
> greg k-h

My bad, I meant to copy this here instead of at the top of me last email:

Now checkpatch complains that:

CHECK: Blank lines aren't necessary after an open brace '{'

So the rule is: don't touch white space unless you absolutely have to?

That is good to know to prevent silly v2's. I know that non-functional
changes are frowned upon; but you also shouldn't sneak in a white space
fixes?

Again, sorry for the silly v2.


  reply	other threads:[~2026-03-08 22:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-08 12:39 [PATCH] powerpc: vas-api: constify dynamic struct class in coproc api register Jori Koolstra
2026-03-08 16:19 ` Greg KH
2026-03-08 22:15   ` Jori Koolstra [this message]
2026-03-09  5:20     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1567347751.876335.1773008140595@kpc.webmail.kpnmail.nl \
    --to=jkoolstra@xs4all.nl \
    --cc=chleroy@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=haren@linux.ibm.com \
    --cc=kees@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=maddy@linux.ibm.com \
    --cc=mpe@ellerman.id.au \
    --cc=npiggin@gmail.com \
    --cc=srikar@linux.ibm.com \
    --cc=sshegde@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox