From: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>
To: linuxppc-dev@lists.ozlabs.org
Cc: Qian Cai <cai@lca.pw>, Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH 0/3] powerpc/module_64: Fix _mcount() stub
Date: Wed, 22 Apr 2020 13:17:49 +0530 [thread overview]
Message-ID: <1587541539.h4m94di1xc.naveen@linux.ibm.com> (raw)
In-Reply-To: <cover.1587488954.git.naveen.n.rao@linux.vnet.ibm.com>
Naveen N. Rao wrote:
> This series addresses the crash reported by Qian Cai on ppc64le with
> -mprofile-kernel here:
> https://lore.kernel.org/r/15AC5B0E-A221-4B8C-9039-FA96B8EF7C88@lca.pw
>
> While fixing patch_instruction() should address the crash, we should
> still change the default stub we setup for _mcount() for cases where a
> kernel is built without ftrace.
I notice that I didn't write that properly yesterday. I meant that this
is required for cases where ftrace gets disabled for any reason,
resulting in the default calls to _mcount() remaining in the kernel
modules.
- Naveen
next prev parent reply other threads:[~2020-04-22 7:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-21 17:35 [PATCH 0/3] powerpc/module_64: Fix _mcount() stub Naveen N. Rao
2020-04-21 17:35 ` [PATCH 1/3] powerpc/module_64: Consolidate ftrace code Naveen N. Rao
2020-04-21 17:35 ` [PATCH 2/3] powerpc/module_64: Simplify check for -mprofile-kernel ftrace relocations Naveen N. Rao
2020-04-21 17:35 ` [PATCH 3/3] powerpc/module_64: Use special stub for _mcount() with -mprofile-kernel Naveen N. Rao
2020-04-24 1:19 ` Qian Cai
2020-04-22 7:47 ` Naveen N. Rao [this message]
2020-06-09 5:29 ` [PATCH 0/3] powerpc/module_64: Fix _mcount() stub Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1587541539.h4m94di1xc.naveen@linux.ibm.com \
--to=naveen.n.rao@linux.vnet.ibm.com \
--cc=cai@lca.pw \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).