From: Paul Mackerras <paulus@samba.org>
To: joakim.tjernlund@lumentis.se
Cc: linuxppc-embedded@lists.linuxppc.org
Subject: Re: New invalidate/clean/flush_dcache functions
Date: Sun, 22 Dec 2002 18:00:11 +1100 [thread overview]
Message-ID: <15877.25339.355590.772957@argo.ozlabs.ibm.com> (raw)
In-Reply-To: <IGEFJKJNHJDCBKALBJLLCEABFJAA.joakim.tjernlund@lumentis.se>
Joakim Tjernlund writes:
> How about adding new xxx_dcache_range() functions functions to PPC.
> Below is my suggestion which is more logical and more efficient:
Why do you say it's more efficient? Because it's inline? Inlining
isn't necessarily a win, you know; by inlining something you can
reduce the number of instructions executed in a particular code path,
but usually you increase the size of the kernel, and together with
that, the icache footprint, which is important because you can execute
quite a lot of instructions in the time taken for one cache miss.
I'm not saying that your functions aren't more efficient, I'm saying
that you haven't established that they are more efficient. Simply
inlining things doesn't necessarily increase efficiency. What you
need to do is to show a measurable increase in efficiency, in the
context of the kernel, which is sufficient to justify the increased
size of the kernel.
The other thing is that you haven't included the synchronization
instructions that are required by the PPC architecture spec.
Paul.
** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/
next prev parent reply other threads:[~2002-12-22 7:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-12-20 16:21 E1/T1 on mpc8260 Omanakuttan
2002-12-20 17:46 ` New invalidate/clean/flush_dcache functions Joakim Tjernlund
2002-12-21 14:25 ` Joakim Tjernlund
2002-12-22 7:00 ` Paul Mackerras [this message]
2002-12-23 13:19 ` SV: " Joakim Tjernlund
2002-12-26 4:12 ` Paul Mackerras
2002-12-26 13:52 ` SV: " Joakim Tjernlund
2004-04-26 16:41 ` High resolution timer in driver bhupinder sahran
2004-04-26 18:06 ` Wolfgang Denk
2004-04-27 15:52 ` bhupinder sahran
2002-12-27 0:58 ` SV: New invalidate/clean/flush_dcache functions Segher Boessenkool
2002-12-27 20:20 ` SV: " Joakim Tjernlund
2002-12-28 4:01 ` Segher Boessenkool
2002-12-23 20:26 ` Dan Malek
2002-12-24 10:36 ` SV: " Joakim Tjernlund
2002-12-24 17:53 ` Dan Malek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15877.25339.355590.772957@argo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=joakim.tjernlund@lumentis.se \
--cc=linuxppc-embedded@lists.linuxppc.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).