From: Paul Mackerras <paulus@samba.org>
To: joakim.tjernlund@lumentis.se
Cc: Dan Malek <dan@embeddededge.com>,
Murray Jensen <Murray.Jensen@csiro.au>,
linuxppc-embedded@lists.linuxppc.org
Subject: RE: [PATCH] 8xx_io/uart.c
Date: Wed, 12 Feb 2003 10:54:02 +1100 [thread overview]
Message-ID: <15945.36122.671574.509514@argo.ozlabs.ibm.com> (raw)
In-Reply-To: <IGEFJKJNHJDCBKALBJLLKECPFKAA.joakim.tjernlund@lumentis.se>
Joakim Tjernlund writes:
> I think I know why the are as they are now. KGDB/XMON stuff is messy and if you
> are sure that XMON/KGDB never outputs a LF all is fine.
Well I can tell you for a fact that xmon will output \n.
Dan, the code looks fragile as it is - why shouldn't the second part
(inside the if (*s == 10) body) do the same test as the first part?
Relying on xmon/kgdb never outputting \n sounds like a bad idea to me.
Paul.
** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/
next prev parent reply other threads:[~2003-02-11 23:54 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-07 13:36 [PATCH] 8xx_io/uart.c Joakim Tjernlund
2003-02-07 16:08 ` Dan Malek
2003-02-07 17:21 ` Joakim Tjernlund
2003-02-09 20:52 ` Dan Malek
2003-02-10 0:29 ` Joakim Tjernlund
2003-02-10 1:08 ` Murray Jensen
2003-02-10 18:52 ` Dan Malek
2003-02-11 1:13 ` Murray Jensen
2003-02-11 16:40 ` Dan Malek
2003-02-11 23:11 ` Murray Jensen
2003-02-11 23:16 ` Murray Jensen
2003-02-11 18:56 ` Tom Rini
2003-02-11 11:16 ` Joakim Tjernlund
2003-02-11 16:03 ` Dan Malek
2003-02-11 18:07 ` Joakim Tjernlund
2003-02-11 23:54 ` Paul Mackerras [this message]
2003-02-14 15:13 ` Joakim Tjernlund
2003-02-14 20:12 ` Dan Malek
2003-02-19 8:43 ` Joakim Tjernlund
-- strict thread matches above, loose matches on Subject: below --
2003-02-07 16:54 Ruhland, Paul
2003-02-07 18:43 ` Joakim Tjernlund
2003-02-10 14:45 ` Joakim Tjernlund
2003-02-10 17:25 ` Tom Rini
2003-02-11 8:33 ` Joakim Tjernlund
[not found] <dan@embeddededge.com>
[not found] ` <3C98DA15.50302@embeddededge.com>
2002-03-21 1:11 ` EV-64260-BP & GT64260 bi_recs Murray Jensen
2002-03-21 6:50 ` Dan Malek
2002-03-21 11:05 ` Murray Jensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15945.36122.671574.509514@argo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=Murray.Jensen@csiro.au \
--cc=dan@embeddededge.com \
--cc=joakim.tjernlund@lumentis.se \
--cc=linuxppc-embedded@lists.linuxppc.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).