From: Paul Mackerras <paulus@samba.org>
To: Cort Dougan <cort@fsmlabs.com>
Cc: linuxppc-dev@lists.linuxppc.org
Subject: Re: [PATCH] vs. latest linuxppc_2_4_devel and linuxppc_2_4 for xmon
Date: Thu, 13 Feb 2003 11:03:29 +1100 [thread overview]
Message-ID: <15946.57553.943418.884633@argo.ozlabs.ibm.com> (raw)
In-Reply-To: <20030212203120.GC12358@host109.fsmlabs.com>
Cort Dougan writes:
> Allows printing of pgtables in xmon. Mighty useful in both trees.
Nice idea. :)
The main problem I have with the patch is that it doesn't check the
pointers in the page table tree, so if the page tables are corrupted
then xmon itself will get a DSI. Yes, if that is the case then your
system is pretty badly hosed, but it is in those sorts of situations
that you most need xmon to work. We should also be using mread() to
read the pagetables safely.
The other problem is that it could print thousands or millions of
lines of output. It would be nice to be able to specify an address or
a range of addresses to look up rather than printing them all.
BTW, we have other points where we need to use mread() - for example I
noticed that the top-level xmon() function calls smp_processor_id(),
which is current->processor, which will break badly if r2 is bad.
Regards,
Paul.
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
prev parent reply other threads:[~2003-02-13 0:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-12 20:31 [PATCH] vs. latest linuxppc_2_4_devel and linuxppc_2_4 for xmon Cort Dougan
2003-02-13 0:03 ` Paul Mackerras [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15946.57553.943418.884633@argo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=cort@fsmlabs.com \
--cc=linuxppc-dev@lists.linuxppc.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).