From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Michael Ellerman <michael@ellerman.id.au>
Cc: Kyungmin Park <kyungmin.park@samsung.com>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH] powerpc/legacy_serial: fix incorrect placement of __initdata tag
Date: Thu, 03 Oct 2013 13:51:27 +0200 [thread overview]
Message-ID: <1600459.LJx7sBeEJs@amdc1032> (raw)
In-Reply-To: <20131001061325.GD17966@concordia>
On Tuesday, October 01, 2013 04:13:25 PM Michael Ellerman wrote:
> On Mon, Sep 30, 2013 at 03:11:42PM +0200, Bartlomiej Zolnierkiewicz wrote:
> > __initdata tag should be placed between the variable name and equal
> > sign for the variable to be placed in the intended .init.data section.
>
> I see lots of other occurences of that in arch/powerpc. Why not send a
> single patch to update them all?
The other occurences while not following the preferred kernel coding style
are (probably) working OK with gcc. This particular occurence just doesn't
work as it should.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
next prev parent reply other threads:[~2013-10-03 11:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-30 13:11 [PATCH] powerpc/legacy_serial: fix incorrect placement of __initdata tag Bartlomiej Zolnierkiewicz
2013-10-01 6:13 ` Michael Ellerman
2013-10-03 11:51 ` Bartlomiej Zolnierkiewicz [this message]
2013-10-08 3:56 ` Michael Ellerman
2013-10-08 9:33 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1600459.LJx7sBeEJs@amdc1032 \
--to=b.zolnierkie@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=michael@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).