From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout4.samsung.com (mailout4.samsung.com [203.254.224.34]) by ozlabs.org (Postfix) with ESMTP id 914AE2C00BB for ; Thu, 3 Oct 2013 21:51:34 +1000 (EST) Received: from epcpsbgm2.samsung.com (epcpsbgm2 [203.254.230.27]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MU300DUVCXVLLL0@mailout4.samsung.com> for linuxppc-dev@lists.ozlabs.org; Thu, 03 Oct 2013 20:51:31 +0900 (KST) From: Bartlomiej Zolnierkiewicz To: Michael Ellerman Subject: Re: [PATCH] powerpc/legacy_serial: fix incorrect placement of __initdata tag Date: Thu, 03 Oct 2013 13:51:27 +0200 Message-id: <1600459.LJx7sBeEJs@amdc1032> In-reply-to: <20131001061325.GD17966@concordia> References: <35419229.o6Cv8JYbpg@amdc1032> <20131001061325.GD17966@concordia> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Cc: Kyungmin Park , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Paul Mackerras List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tuesday, October 01, 2013 04:13:25 PM Michael Ellerman wrote: > On Mon, Sep 30, 2013 at 03:11:42PM +0200, Bartlomiej Zolnierkiewicz wrote: > > __initdata tag should be placed between the variable name and equal > > sign for the variable to be placed in the intended .init.data section. > > I see lots of other occurences of that in arch/powerpc. Why not send a > single patch to update them all? The other occurences while not following the preferred kernel coding style are (probably) working OK with gcc. This particular occurence just doesn't work as it should. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics