From: Arnd Bergmann <arnd@arndb.de>
To: linuxppc-dev@lists.ozlabs.org
Cc: Daniel Axtens <dja@axtens.net>, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 5/6] powerpc/sparse: Pass endianness to sparse
Date: Mon, 04 Jul 2016 09:52:53 +0200 [thread overview]
Message-ID: <16028701.SzybLq93oN@wuerfel> (raw)
In-Reply-To: <1467616182-30886-5-git-send-email-dja@axtens.net>
On Monday, July 4, 2016 5:09:41 PM CEST Daniel Axtens wrote:
> ---
> arch/powerpc/Makefile | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/powerpc/Makefile b/arch/powerpc/Makefile
> index 709a22a3e824..8617c71c3bdb 100644
> --- a/arch/powerpc/Makefile
> +++ b/arch/powerpc/Makefile
> @@ -181,6 +181,11 @@ KBUILD_CFLAGS += -pipe -Iarch/$(ARCH) $(CFLAGS-y)
> CPP = $(CC) -E $(KBUILD_CFLAGS)
>
> CHECKFLAGS += -m$(CONFIG_WORD_SIZE) -D__powerpc__ -D__powerpc$(CONFIG_WORD_SIZE)__
> +ifdef CONFIG_CPU_BIG_ENDIAN
> +CHECKFLAGS += -D__BIG_ENDIAN__
> +else
> +CHECKFLAGS += -D__LITTLE_ENDIAN__
> +endif
>
> KBUILD_LDFLAGS_MODULE += arch/powerpc/lib/crtsavres.o
Looks good, thanks!
I've taken a short look at the other patches in the series too and found
a few minor glitches, the rest looks good to me.
Arnd
next prev parent reply other threads:[~2016-07-04 7:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-04 7:09 [PATCH 1/6] powerpc/kvm: Clarify __user annotations Daniel Axtens
2016-07-04 7:09 ` [PATCH 2/6] powerpc/kernel: Drop annotation for generic, unannotated function Daniel Axtens
2016-07-04 7:09 ` [PATCH 3/6] powerpc/xics: Fully qualify cast to silence sparse Daniel Axtens
2016-07-04 7:27 ` Andrew Donnellan
2016-07-04 7:46 ` Arnd Bergmann
2016-07-04 7:09 ` [PATCH 4/6] powerpc/kernel: Clean up some sparse warnings Daniel Axtens
2016-07-04 7:50 ` Arnd Bergmann
2016-07-04 7:09 ` [PATCH 5/6] powerpc/sparse: Pass endianness to sparse Daniel Axtens
2016-07-04 7:32 ` Andrew Donnellan
2016-07-04 7:52 ` Arnd Bergmann [this message]
2016-07-04 7:09 ` [PATCH 6/6] powerpc/sparse: Make ppc_md.{halt, restart} __noreturn Daniel Axtens
2016-07-04 10:20 ` kbuild test robot
2016-07-04 7:26 ` [PATCH 1/6] powerpc/kvm: Clarify __user annotations Andrew Donnellan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16028701.SzybLq93oN@wuerfel \
--to=arnd@arndb.de \
--cc=dja@axtens.net \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).